Open
Conversation
Signed-off-by: J-K. Solbakken <jk@jksolbakken.no>
Signed-off-by: J-K. Solbakken <jk@jksolbakken.no>
Signed-off-by: J-K. Solbakken <jk@jksolbakken.no>
Signed-off-by: J-K. Solbakken <jk@jksolbakken.no>
Signed-off-by: J-K. Solbakken <jk@jksolbakken.no>
Member
|
Hi, Thank you for your contribution, I'm reviewing it. Did you use a tool to change the actions tags by their corresponding hash ? |
lunika
reviewed
Jan 8, 2026
| services: | ||
| postgres: | ||
| image: postgres:16 | ||
| image: index.docker.io/library/postgres@sha256:d4c3314b2dd74ff23cd6cd07e4d7e737cb6ef791c22a7cbd744cfbfb4815df72 # ratchet:postgres:16 |
Member
There was a problem hiding this comment.
Did zizmor report this ?
I revert it and zizmor is not warning me.
| path: "src/frontend/**/node_modules" | ||
| key: front-node_modules-${{ hashFiles('src/frontend/**/yarn.lock') }} | ||
| fail-on-cache-miss: true | ||
| lookup-only: true |
Member
There was a problem hiding this comment.
Not sure if we should use it here. We want to download the cache.
Comment on lines
+157
to
+175
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Member
There was a problem hiding this comment.
You can remove all this lines I think :-)
Author
|
The tool I used to pin the hashes is called Ratchet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Some suggestions on improving the security of the workflows as detected by Zizmor
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)