✨(backend) manage reconciliation requests for user accounts by Ash-Crow · Pull Request #1708 · suitenumerique/docs

Ash-Crow · 2025-12-08T18:18:34Z

Purpose

For now, the reconciliation requests are imported through CSV in the Django admin, which sends confirmation email to both addresses. When both are checked, the actual reconciliation is processed, in a threefold process (update document acess, update invitations, update user status.)

Proposal

Demo page reconciliation success

In waiting for @rl-83 to provide the design:

src/backend/core/tasks/user_reconciliation.py

src/backend/core/models.py

lunika · 2026-01-16T15:38:03Z

After discussion with @AntoLC some data migration are missing.
Other relations with the user exists in the database and this data will be lost if not transfered.
When a user visit a docs it doesn't have access (a public or connected one), an entry is added to the LinkTrace model. These docs will be shown to the user on its homepage. This table should also be migrated.
Same for the DocumentFavorite model. Should be migrated.

There are also relation with Thread, Comment and Reaction. But I don't know if they should be migrated. WDYT @virgile-dev @rl-83 ? A thread (the comment container) and comments should be migrated from the inactive user to the new one ?

For now, the reconciliation requests are imported through CSV in the Django admin, which sends confirmation email to both addresses. When both are checked, the actual reconciliation is processed, in a threefold process (update document acess, update invitations, update user status.)

github-actions · 2026-01-20T13:51:33Z

Size Change: +6.14 kB (+0.15%)

Total Size: 4.2 MB

Filename	Size	Change
`apps/impress/out/_next/static/b7611922/_buildManifest.js`	896 B	+896 B (new file)	🆕
`apps/impress/out/_next/static/chunks/3642.js`	0 B	-783 kB (removed)	🏆
`apps/impress/out/_next/static/chunks/6605.js`	780 kB	+780 kB (new file)	🆕
`apps/impress/out/_next/static/chunks/pages/_app.js`	600 kB	+5.11 kB (+0.86%)
`apps/impress/out/_next/static/chunks/pages/user-reconciliations/active/[id].js`	1.42 kB	+1.42 kB (new file)	🆕
`apps/impress/out/_next/static/chunks/pages/user-reconciliations/inactive/[id].js`	1.42 kB	+1.42 kB (new file)	🆕
`apps/impress/out/_next/static/d33b0515/_buildManifest.js`	0 B	-831 B (removed)	🏆
`apps/impress/out/user-reconciliations/active/[id]/index.html`	1.23 kB	+1.23 kB (new file)	🆕
`apps/impress/out/user-reconciliations/inactive/[id]/index.html`	1.23 kB	+1.23 kB (new file)	🆕

_{compressed-size-action}

This changes the way the reconciliation requests CSV imports are processed and requires the CSV to provide a unique id for each request. Rows with errors are also now handled better so that they don't fail the whole import.

…ocs into sbl/user-reconciliation

This removes the new email template in favor of using the already existing one, by removing the extra formating.

Process each reconciliation requests individually as a transaction, with the bulk updates/deletes made for each requests, to avoid interference between requests and unwanted states

Adds management of link traces and documents favorites in the reconciliation requests.

Ash-Crow · 2026-02-03T18:44:00Z

After discussion with @AntoLC some data migration are missing. Other relations with the user exists in the database and this data will be lost if not transfered. When a user visit a docs it doesn't have access (a public or connected one), an entry is added to the LinkTrace model. These docs will be shown to the user on its homepage. This table should also be migrated. Same for the DocumentFavorite model. Should be migrated.

Done.

There are also relation with Thread, Comment and Reaction. But I don't know if they should be migrated. WDYT @virgile-dev @rl-83 ? A thread (the comment container) and comments should be migrated from the inactive user to the new one ?

Done as well, if not needed we can put it behind a toggle controlled by an env variable.

Adds management of threads, comments and reactions in the reconciliation requests.

This adds unit tests for the new API view that is used when a confirmation link is clicked in an email.

lunika

Few nitepicking otherwise it's good to me

lunika · 2026-02-06T07:29:29Z

src/backend/core/api/viewsets.py

 from rest_framework import filters, status, viewsets
 from rest_framework import response as drf_response
 from rest_framework.permissions import AllowAny
+from rest_framework.response import Response


line 41 the drf reponse module is imported, you can probably use it instead of making an other import ?

lunika · 2026-02-06T07:33:02Z

src/backend/core/models.py

+        """Generate and send email to the user from a template."""
+        emails = [self.email]
+        context = context or {}
+        domain = Site.objects.get_current().domain


You should do like in this PR : #1825

lunika

Didn't saw you have merge commits in your commits history.
You have to remove them

AntoLC · 2026-02-06T08:57:41Z

CHANGELOG.md

 - ✨(helm) redirecting system #1697
 - 📱(frontend) add comments for smaller device #1737
 - ✨(project) add custom js support via config #1759
+- ✨(backend) manage reconciliation requests for user accounts #1708


Should be placed under "Unreleased"

Ash-Crow force-pushed the sbl/user-reconciliation branch 4 times, most recently from 4d4bd60 to ab55e01 Compare December 11, 2025 08:28

Ash-Crow requested review from lunika and removed request for lunika December 15, 2025 09:12

Ash-Crow force-pushed the sbl/user-reconciliation branch 11 times, most recently from 35c4d49 to 5090839 Compare December 15, 2025 21:49

Ash-Crow force-pushed the sbl/user-reconciliation branch 8 times, most recently from 47099e1 to 57050a1 Compare January 12, 2026 16:54

Ash-Crow mentioned this pull request Jan 12, 2026

Add a front route for user reconciliations #1791

Open

lunika reviewed Jan 14, 2026

View reviewed changes

AntoLC assigned Ash-Crow and AntoLC Jan 15, 2026

AntoLC added the frontend label Jan 15, 2026

AntoLC force-pushed the sbl/user-reconciliation branch from 052b0b3 to d32ef62 Compare January 15, 2026 17:15

Ash-Crow and others added 3 commits January 20, 2026 14:44

✨(frontend) add email validation pages

a511180

fix

032413a

Ash-Crow force-pushed the sbl/user-reconciliation branch from d32ef62 to 032413a Compare January 20, 2026 13:45

Merge branch 'main' into sbl/user-reconciliation

af523e1

Ash-Crow added 5 commits January 27, 2026 18:13

✨(backend) reconciliation requests: use a source unique id

dc8db60

This changes the way the reconciliation requests CSV imports are processed and requires the CSV to provide a unique id for each request. Rows with errors are also now handled better so that they don't fail the whole import.

Merge branch 'main' into sbl/user-reconciliation

b9e341b

✨(backend) reconciliation requests: use a source unique id

c121441

This changes the way the reconciliation requests CSV imports are processed and requires the CSV to provide a unique id for each request. Rows with errors are also now handled better so that they don't fail the whole import.

Merge branch 'sbl/user-reconciliation' of github.com:suitenumerique/d…

97f02ff

…ocs into sbl/user-reconciliation

✨(backend) reconciliation requests: use the standard email template

c65ab34

This removes the new email template in favor of using the already existing one, by removing the extra formating.

Ash-Crow force-pushed the sbl/user-reconciliation branch from 0d2b538 to c65ab34 Compare February 2, 2026 17:18

Ash-Crow added 2 commits February 3, 2026 10:48

✨(backend) process reconciliation requests as transactions

313e14d

Process each reconciliation requests individually as a transaction, with the bulk updates/deletes made for each requests, to avoid interference between requests and unwanted states

✨(backend) reconciliation requests update link traces and doc favorites

61c81de

Adds management of link traces and documents favorites in the reconciliation requests.

Ash-Crow force-pushed the sbl/user-reconciliation branch from cb97eee to 1dc375e Compare February 3, 2026 18:57

✨(backend) reconciliation requests update comments

b3e69ea

Adds management of threads, comments and reactions in the reconciliation requests.

Ash-Crow force-pushed the sbl/user-reconciliation branch from 1dc375e to b3e69ea Compare February 4, 2026 08:50

Ash-Crow marked this pull request as ready for review February 4, 2026 09:27

Ash-Crow force-pushed the sbl/user-reconciliation branch from 9784cce to 7e36d91 Compare February 4, 2026 09:33

✨(backend) add unit tests for the api view for reconciliation requests

2a8e51a

This adds unit tests for the new API view that is used when a confirmation link is clicked in an email.

Ash-Crow force-pushed the sbl/user-reconciliation branch from 7e36d91 to 2a8e51a Compare February 4, 2026 09:49

Ash-Crow requested review from AntoLC and lunika February 4, 2026 09:54

lunika approved these changes Feb 6, 2026

View reviewed changes

fixup! ✨(frontend) add email validation pages

5a23ecf

lunika requested changes Feb 6, 2026

View reviewed changes

AntoLC reviewed Feb 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨(backend) manage reconciliation requests for user accounts#1708

✨(backend) manage reconciliation requests for user accounts#1708
Ash-Crow wants to merge 14 commits intomainfrom
sbl/user-reconciliation

Ash-Crow commented Dec 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lunika commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

Ash-Crow commented Feb 3, 2026

Uh oh!

lunika left a comment

Uh oh!

lunika Feb 6, 2026

Uh oh!

lunika Feb 6, 2026

Uh oh!

lunika left a comment

Uh oh!

AntoLC Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Ash-Crow commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Proposal

Demo page reconciliation success

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lunika commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ash-Crow commented Feb 3, 2026

Uh oh!

lunika left a comment

Choose a reason for hiding this comment

Uh oh!

lunika Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

lunika Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

lunika left a comment

Choose a reason for hiding this comment

Uh oh!

AntoLC Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ash-Crow commented Dec 8, 2025 •

edited

Loading

github-actions bot commented Jan 20, 2026 •

edited

Loading