-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: tooltip position for several elements #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ All Jest tests passed! This PR is ready to merge. |
|
The reason some of the tooltips are on the left is because those menu items have pull downs or confirmations that appear below. For example, New Project. Not sure I agree with these changes. |
|
Ah I see! |
|
Sure. Hiding them on click would be a better solution. |
|
✅ All Jest tests passed! This PR is ready to merge. |
|
You are still planning to hide the tooltips on click? |
|
Yess. Sorry if the activity due to syncing my fork caught your attention unnecessarily. |
|
I think it is going to have to be something that gets triggered in js/toolbar.js |
Merging this pr will shift the position of the tooltips for elements with tooltip position set to left to bottom.
For various elements, the
data-positionattribute is set toleft. This makes the tooltips for these elements appear on the left, hiding other elements. I set the attribute tobottominstead for all these. Obviously the behaviour now hides the bottom elements, but I think (and welcome suggestions on this) that covering the non-related elements provides a better ux than covering the "sibling" or the related elements.Fixes #4809