Skip to content

Conversation

@theAnuragMishra
Copy link

@theAnuragMishra theAnuragMishra commented Nov 29, 2025

Merging this pr will shift the position of the tooltips for elements with tooltip position set to left to bottom.
For various elements, the data-position attribute is set to left. This makes the tooltips for these elements appear on the left, hiding other elements. I set the attribute to bottom instead for all these. Obviously the behaviour now hides the bottom elements, but I think (and welcome suggestions on this) that covering the non-related elements provides a better ux than covering the "sibling" or the related elements.

Fixes #4809

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

The reason some of the tooltips are on the left is because those menu items have pull downs or confirmations that appear below. For example, New Project. Not sure I agree with these changes.

@theAnuragMishra
Copy link
Author

Ah I see!
I checked for the existence of pull downs that could be obstructed by the tooltip appearing below. But I found none at that time, because I didn't click on the buttons.
Now, yes the tooltip position, if set to below on some of these, will cover the pull downs.
But I think a better solution would be to hide the tooltip on clicking, because they should show as long as the element is hovered (which I think ends when it is clicked, at least behaviorally if not technically.
So should I adjust the tooltip behavior to hide when the element is clicked and update the pr?

@walterbender
Copy link
Member

Sure. Hiding them on click would be a better solution.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

✅ All Jest tests passed! This PR is ready to merge.

@walterbender
Copy link
Member

You are still planning to hide the tooltips on click?

@theAnuragMishra
Copy link
Author

Yess. Sorry if the activity due to syncing my fork caught your attention unnecessarily.
Actually I was looking for a way to hide the tooltip but it's taking some time as I'm not very familiar with materalize css. Could you give me a lead on this?

@walterbender
Copy link
Member

I think it is going to have to be something that gets triggered in js/toolbar.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Bug (Hover Blockage)

2 participants