fix Widget block gets disable after Restore #4670

[kaiju-no-9]

The pie menu's "Delete" button was calling an extra function, that.blocks.extract(), before calling that.blocks.sendStackToTrash().

The extract() function (which is meant to pull a block from the middle of a stack) was breaking the widget's internal state before it was even sent to the trash. The drag-and-drop delete function only calls sendStackToTrash(), which is why it worked correctly.

[github-actions]

✅ All Jest tests passed! This PR is ready to merge.

[Commanderk3]

@kaiju-no-9 I have tested. Seems to be working fine 👍

[suryaanshah]

@Commanderk3 Removing the extract function does appear to fix the widget block issue (as noted in the original issue thread), but it was originally added for a reason. We should understand the implications before removing it outright.

[kaiju-no-9]

@suryaanshah yes one should look for it if i does cause any issue but this was the only place cause the bug i went through all the code__base and rest all is working fine

[walterbender]

Yes, but.

The extract is important when you are sending a block that is in a stack to the trash. To load the default project and then try sending the top note block to the trash. W/o your change, just the note block is sent to the trash. With your change, all of the note blocks are sent to the trash.

[kaiju-no-9]

I understood, will look forward to finding a better solution

[walterbender]

Here is my latest theory: the extract process is not pulling the "hidden" block at the end of the stack. (All clamp blocks have a hidden block attached... if it is not there, the clamp block will not execute.)

[walterbender]

@kaiju-no-9 were you able to test my hypothesis?