Skip to content

Feat/r2d pump lockout #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
r-kirkbride wants to merge 9 commits into
base: dyno
Choose a base branch
from
Open

Feat/r2d pump lockout #251

r-kirkbride wants to merge 9 commits into from

Conversation

@r-kirkbride
Copy link
Contributor

@r-kirkbride r-kirkbride commented Feb 25, 2025

Changes

  • Subscribe to PDM_Output_Voltage
  • Check pumps running (PDM_Output_Voltage) before entering R2D

Fixed Issue(s)

Closes #238

Checklist

  • Code has been tested on STM32 hardware.
  • Changes do not generate any new compiler warnings.
  • Code has been formatted using trunk fmt.
  • Commit messages follow the Conventional Commits specification.

@r-kirkbride r-kirkbride self-assigned this Feb 25, 2025
@Avdieienko
Copy link
Member

Avdieienko commented Feb 25, 2025

@r-kirkbride Update can-defs submodule to be on the feat/r2d-pump-lockout branch and I will test it on a car later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avdieienko Avdieienko Awaiting requested review from Avdieienko

At least 1 approving review is required to merge this pull request.

Assignees

@r-kirkbride r-kirkbride

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-kirkbride @Avdieienko