Improve scroll at bottom to support scrolling without focus

[guillaumeboehm]

Took a shot at improving a bit the autoscroll logic, I'm using the mouse to scroll from time to time and the previous implementation was not supporting that.

I also added a config to always autoscroll, I felt like it could be useful. If you don't like it it's separated in its own commit.

[cameronr]

Nice! I've also been a little annoyed when i've scrolled the view up (but not repositioned the cursor).

My only suggestion is that I don't think output_window_at_bottom needs to be in state. I think it would be fine to have something like output_window.viewport_at_bottom and renderer can just check that.

[guillaumeboehm]

Nice! I've also been a little annoyed when i've scrolled the view up (but not repositioned the cursor).

My only suggestion is that I don't think output_window_at_bottom needs to be in state. I think it would be fine to have something like output_window.viewport_at_bottom and renderer can just check that.

Yep that's easier to maintain and I could remove some manual reset 😄 thanks for the review!

[sudo-tee]

@guillaumeboehm
This looks pretty reasonable to me.

One minor change. I would ask.

There is a lot of uneeded comments in the MR.

I usually try to put comments on things that are not obious.

[sudo-tee]

Thanks for fixing my nitpicking :)