fix(extensions)!: random extraneous argument for repeat varchar#1015
Merged
yongchul merged 1 commit intosubstrait-io:mainfrom Mar 20, 2026
Merged
fix(extensions)!: random extraneous argument for repeat varchar#1015yongchul merged 1 commit intosubstrait-io:mainfrom
yongchul merged 1 commit intosubstrait-io:mainfrom
Conversation
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua,
westonpace and
yongchul
as code owners
mbwhite
changed the title
vbarua
approved these changes
Mar 19, 2026
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Nice catch. This is obviously incorrect. This counts as a breaking change, but anything trying to use that specific signature would not / should not have been able to do so.
vbarua
changed the title
yongchul
approved these changes
Mar 19, 2026
Member
|
who's doing the honors and merges this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extension definition for
repeat()is correct for typestrbut for thevarcharthere was a randomvalueentry.