feat(tests): add enum argument support to FuncTestCase grammar#1010
Merged
nielspardon merged 1 commit intosubstrait-io:mainfrom Mar 23, 2026
Merged
feat(tests): add enum argument support to FuncTestCase grammar#1010nielspardon merged 1 commit intosubstrait-io:mainfrom
nielspardon merged 1 commit intosubstrait-io:mainfrom
Conversation
nielspardon
requested review from
EpsilonPrime,
cpcloud,
jacques-n,
vbarua,
westonpace and
yongchul
as code owners
nielspardon
force-pushed
the
par-enum-arg
branch
from
065d5b6 to
fcd29c6
Compare
This was referenced Mar 17, 2026
vbarua
approved these changes
Mar 17, 2026
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Treating enums as their own type makes sense to me.
benbellick
approved these changes
Mar 17, 2026
Member
benbellick
left a comment
benbellick
left a comment
There was a problem hiding this comment.
This is great, thanks!
It would be great in the future to validate that the enum values used in the tests are allowed enum values (e.g. HOUR is valid for extract, but BLAHBLAH is not) though I think leaving that for a future PR is wise.
yongchul
approved these changes
Mar 19, 2026
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-enum-arg
branch
from
fcd29c6 to
43b3c34
Compare
Member
Author
|
I rebased and resolved the conflicts. Github offers me to merge the PR myself with the given approvals. Is it ok if I do this as a committer or should a PMC member push the button here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the FuncTestCase grammar enum arguments where not handled as enum arguments but as string literals (only example so far the datetime
extractfunction).enumdata type in the grammar.extracttest cases are updated to use the new syntax.