test: add DynamicParameter and DynamicParameterBinding roundtrip tests#481
Closed
bvolpato wants to merge 1 commit intosubstrait-io:mainfrom
Closed
test: add DynamicParameter and DynamicParameterBinding roundtrip tests#481bvolpato wants to merge 1 commit intosubstrait-io:mainfrom
bvolpato wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
bvolpato
force-pushed
the
bv/dynamic-parameter-tests
branch
from
6267b90 to
05ac0f5
Compare
Add tests validating proto roundtrip for DynamicParameter expressions, DynamicParameterBinding, plan-level integration with filter and project relations, multiple parameters, and serde JSON roundtrip.
bvolpato
force-pushed
the
bv/dynamic-parameter-tests
branch
from
05ac0f5 to
93fb7fc
Compare
Member
Author
|
Spoke with @benbellick in person and we can defer tests for whenever we have builders instead of using bindings directly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive tests validating the auto-generated
DynamicParameterandDynamicParameterBindingproto types, ensuring they serialize and deserialize correctly through both protobuf binary and JSON (serde) roundtrips.This complements the DynamicParameter support recently added in substrait-java#752 and substrait-go#215.
Tests Added (5 tests)
dynamic_parameter_expression_roundtripDynamicParameteras an expressionRexTypedynamic_parameter_binding_roundtripDynamicParameterBindingwith an i32 literalplan_with_dynamic_parameter_roundtripDynamicParameterin a filter condition and aParameterBindingmultiple_dynamic_parameters_in_planDynamicParameterexpressions (i32, fp64) in a project, with two bindingsdynamic_parameter_serde_roundtripserdefeature) for a plan with dynamic parametersValidation
cargo test --all-features— all 68 tests passcargo fmt -- --check— cleancargo clippy --all-features -- -D warnings— no warnings