fix(javadoc): partial isthmus#765
Merged
bestbeforetoday merged 2 commits intosubstrait-io:mainfrom Mar 19, 2026
Merged
Conversation
bestbeforetoday
requested changes
Mar 18, 2026
Member
bestbeforetoday
left a comment
bestbeforetoday
left a comment
There was a problem hiding this comment.
Generally seems fine to me but a few comments that I think are worth some minor rework.
isthmus/src/main/java/io/substrait/isthmus/SqlExpressionToSubstrait.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SqlExpressionToSubstrait.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java
Outdated
Show resolved
Hide resolved
isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
force-pushed
the
fix-javadoc-c-006
branch
from
171d7d5 to
e9c769c
Compare
bestbeforetoday
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.