refactor: remove new but deprecated constructors

Author: vbarua

isthmus/src/main/java/io/substrait/isthmus/SqlToSubstrait.java

@@ -22,13 +22,7 @@ public class SqlToSubstrait extends SqlConverterBase {
   protected final ConverterProvider converterProvider;
 
   public SqlToSubstrait() {
-    this(DefaultExtensionCatalog.DEFAULT_COLLECTION);
-  }
-
-  /** Use {@link SqlToSubstrait#SqlToSubstrait(ConverterProvider)} instead */
-  @Deprecated
-  public SqlToSubstrait(SimpleExtension.ExtensionCollection extensions) {
-    this(new ConverterProvider(extensions));
+    this(new ConverterProvider());
   }
 
   public SqlToSubstrait(ConverterProvider converterProvider) {

isthmus/src/main/java/io/substrait/isthmus/SubstraitRelVisitor.java

@@ -87,23 +87,6 @@ public SubstraitRelVisitor(
     this(new ConverterProvider(typeFactory, extensions));
   }
 
-  /** Use {@link SubstraitRelVisitor#SubstraitRelVisitor(ConverterProvider)} */
-  @Deprecated
-  public SubstraitRelVisitor(
-      RelDataTypeFactory typeFactory,
-      ScalarFunctionConverter scalarFunctionConverter,
-      AggregateFunctionConverter aggregateFunctionConverter,
-      WindowFunctionConverter windowFunctionConverter,
-      TypeConverter typeConverter) {
-    this(
-        new ConverterProvider(
-            typeFactory,
-            scalarFunctionConverter,
-            aggregateFunctionConverter,
-            windowFunctionConverter,
-            typeConverter));
-  }
-
   public SubstraitRelVisitor(ConverterProvider converterProvider) {
     this.typeConverter = converterProvider.getTypeConverter();
     this.aggregateFunctionConverter = converterProvider.getAggregateFunctionConverter();