Skip to content

Commit f1e4107

Browse files
committed
feat: expose ConverterProvider methods
1 parent 74cdf17 commit f1e4107

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

isthmus/src/main/java/io/substrait/isthmus/ConverterProvider.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public ConverterProvider(
9191
* {@link SqlParser.Config} is a Calcite class which controls SQL parsing behaviour like
9292
* identifier casing.
9393
*/
94-
protected SqlParser.Config getSqlParserConfig() {
94+
public SqlParser.Config getSqlParserConfig() {
9595
return SqlParser.Config.DEFAULT
9696
.withUnquotedCasing(Casing.TO_UPPER)
9797
.withParserFactory(SqlDdlParserImpl.FACTORY)
@@ -102,15 +102,15 @@ protected SqlParser.Config getSqlParserConfig() {
102102
* {@link CalciteConnectionConfig} is a Calcite class which controls SQL processing behaviour like
103103
* table name case-sensitivity.
104104
*/
105-
protected CalciteConnectionConfig getCalciteConnectionConfig() {
105+
public CalciteConnectionConfig getCalciteConnectionConfig() {
106106
return CalciteConnectionConfig.DEFAULT.set(CalciteConnectionProperty.CASE_SENSITIVE, "false");
107107
}
108108

109109
/**
110110
* {@link SqlToRelConverter.Config} is a Calcite class which controls SQL processing behaviour
111111
* like field-trimming.
112112
*/
113-
protected SqlToRelConverter.Config getSqlToRelConverterConfig() {
113+
public SqlToRelConverter.Config getSqlToRelConverterConfig() {
114114
return SqlToRelConverter.config().withTrimUnusedFields(true).withExpand(false);
115115
}
116116

@@ -119,7 +119,7 @@ protected SqlToRelConverter.Config getSqlToRelConverterConfig() {
119119
* org.apache.calcite.sql.SqlOperator}s available and controls valid identifiers during SQL
120120
* processing.
121121
*/
122-
protected SqlOperatorTable getSqlOperatorTable() {
122+
public SqlOperatorTable getSqlOperatorTable() {
123123
return SubstraitOperatorTable.INSTANCE;
124124
}
125125

@@ -152,15 +152,15 @@ protected SubstraitToCalcite getSubstraitToCalcite(Prepare.CatalogReader catalog
152152
* A {@link SubstraitRelVisitor} converts Calcite {@link org.apache.calcite.rel.RelNode}s to
153153
* Substrait {@link Rel}s
154154
*/
155-
protected SubstraitRelVisitor getSubstraitRelVisitor() {
155+
public SubstraitRelVisitor getSubstraitRelVisitor() {
156156
return new SubstraitRelVisitor(this);
157157
}
158158

159159
/**
160160
* A {@link RexExpressionConverter} converts Calcite {@link org.apache.calcite.rex.RexNode}s to
161161
* Substrait equivalents.
162162
*/
163-
protected RexExpressionConverter getRexExpressionConverter(SubstraitRelVisitor srv) {
163+
public RexExpressionConverter getRexExpressionConverter(SubstraitRelVisitor srv) {
164164
return new RexExpressionConverter(
165165
srv, getCallConverters(), getWindowFunctionConverter(), getTypeConverter());
166166
}
@@ -169,7 +169,7 @@ protected RexExpressionConverter getRexExpressionConverter(SubstraitRelVisitor s
169169
* {@link CallConverter}s are used to convert Calcite {@link org.apache.calcite.rex.RexCall}s to
170170
* Substrait equivalents.
171171
*/
172-
protected List<CallConverter> getCallConverters() {
172+
public List<CallConverter> getCallConverters() {
173173
ArrayList<CallConverter> callConverters = new ArrayList<>();
174174
callConverters.add(new FieldSelectionConverter(typeConverter));
175175
callConverters.add(CallConverters.CASE);
@@ -191,7 +191,7 @@ protected List<CallConverter> getCallConverters() {
191191
*
192192
* <p>Override to customize the schema generation behaviour
193193
*/
194-
protected Function<Rel, CalciteSchema> getSchemaResolver() {
194+
public Function<Rel, CalciteSchema> getSchemaResolver() {
195195
SchemaCollector schemaCollector = new SchemaCollector(this);
196196
return schemaCollector::toSchema;
197197
}
@@ -200,15 +200,15 @@ protected Function<Rel, CalciteSchema> getSchemaResolver() {
200200
* A {@link SubstraitRelNodeConverter} is used when converting from Substrait {@link Rel}s to
201201
* Calcite {@link org.apache.calcite.rel.RelNode}s.
202202
*/
203-
protected SubstraitRelNodeConverter getSubstraitRelNodeConverter(RelBuilder relBuilder) {
203+
public SubstraitRelNodeConverter getSubstraitRelNodeConverter(RelBuilder relBuilder) {
204204
return new SubstraitRelNodeConverter(relBuilder, this);
205205
}
206206

207207
/**
208208
* A {@link ExpressionRexConverter} converts Substrait {@link io.substrait.expression.Expression}
209209
* to Calcite equivalents
210210
*/
211-
protected ExpressionRexConverter getExpressionRexConverter(
211+
public ExpressionRexConverter getExpressionRexConverter(
212212
SubstraitRelNodeConverter relNodeConverter) {
213213
ExpressionRexConverter erc =
214214
new ExpressionRexConverter(
@@ -224,7 +224,7 @@ protected ExpressionRexConverter getExpressionRexConverter(
224224
* A {@link RelBuilder} is a Calcite class used as a factory for creating {@link
225225
* org.apache.calcite.rel.RelNode}s.
226226
*/
227-
protected RelBuilder getRelBuilder(CalciteSchema schema) {
227+
public RelBuilder getRelBuilder(CalciteSchema schema) {
228228
return RelBuilder.create(Frameworks.newConfigBuilder().defaultSchema(schema.plus()).build());
229229
}
230230

isthmus/src/main/java/io/substrait/isthmus/DynamicConverterProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public DynamicConverterProvider(
2424
}
2525

2626
@Override
27-
protected List<CallConverter> getCallConverters() {
27+
public List<CallConverter> getCallConverters() {
2828
List<CallConverter> callConverters = super.getCallConverters();
2929

3030
SimpleExtension.ExtensionCollection dynamicExtensionCollection =
@@ -45,7 +45,7 @@ protected List<CallConverter> getCallConverters() {
4545
}
4646

4747
@Override
48-
protected SqlOperatorTable getSqlOperatorTable() {
48+
public SqlOperatorTable getSqlOperatorTable() {
4949
SimpleExtension.ExtensionCollection dynamicExtensionCollection =
5050
ExtensionUtils.getDynamicExtensions(extensions);
5151
if (!dynamicExtensionCollection.scalarFunctions().isEmpty()

0 commit comments

Comments
 (0)