DO NOT MERGE: Debug CI#246
Closed
ingomueller-net wants to merge 16 commits intosubstrait-io:mainfrom
Closed
Conversation
Bumps [substrait-java](https://github.com/substrait-io/substrait-java) from `49b0210` to `33c83dc`. - [Release notes](https://github.com/substrait-io/substrait-java/releases) - [Commits](substrait-io/substrait-java@49b0210...33c83dc) --- updated-dependencies: - dependency-name: substrait-java dependency-version: 33c83dc2babb4114607333d8299eced88e4afa01 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
The only change is the addition of the `Version` field, which is expected given substrait-io/substrait-java#406. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
debug-ci
branch
from
7edb496 to
fb71c45
Compare
nielspardon
reviewed
Jun 12, 2025
|
|
||
| - name: Fetch history and tags of submodules | ||
| # This is needed for `substrait-java` or one of its submodules to determine its version. | ||
| run: git submodule foreach --recursive 'git fetch --unshallow || true' |
Member
There was a problem hiding this comment.
what happens when you add the following after this command?
cd substrait-java/substrait; git describe --tags
Contributor
Author
There was a problem hiding this comment.
The tags seem to be present correctly, see CI log.
Closed
This reverts commit a7fcea0.
Member
|
Hi! This seems stale? Should we close? |
Contributor
Author
|
Yeah, of course. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.