-
Notifications
You must be signed in to change notification settings - Fork 8
[release] upgrade Staking, StakingManager to mainnet #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughAdded Corepack initialization to multiple GitHub Actions workflows so Corepack runs before Yarn; updated mainnet publish data for Staking and StakingManager (addresses, bytecode hashes, timestamps); bumped package version from 1.10.0-1 to 1.10.0. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Node as setup-node (Node 18)
participant Corepack as corepack
participant Yarn as yarn
GH->>Node: setup Node 18
Note right of Node: existing step
Node-->>GH: Node ready
GH->>Corepack: run "corepack enable"
Corepack-->>GH: Corepack enabled
GH->>Yarn: run "yarn" (or "corepack enable && yarn")
Yarn-->>GH: dependencies installed / commands run
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/docs-deploy.yml (1)
13-13: Corepack initialization uses inline chaining—functionally equivalent and acceptable.While this workflow uses inline command chaining (
corepack enable && yarn) instead of separate steps like other workflows, both approaches are functionally identical. The inline format is reasonable for this simpler workflow that doesn't have explicit setup-node configuration. For consistency across the repository, consider aligning the format with other workflows (separate- run: corepack enablestep), but this is a minor stylistic preference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.github/workflows/deploy.yml(1 hunks).github/workflows/docs-deploy.yml(1 hunks).github/workflows/fuzz.yml(1 hunks).github/workflows/pr.yml(1 hunks).github/workflows/prerelease.yml(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/upgrade.yml(1 hunks)publish/mainnet.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (7)
publish/mainnet.json (1)
84-87: Verify mainnet contract addresses and bytecode hashes before merging.The Staking and StakingManager contract data (addresses and bytecode hashes) have been updated for production mainnet deployment. These changes require confirmation to prevent user funds from being directed to incorrect contract instances.
Verify the following:
- New innerAddresses are correct and match deployed contracts on mainnet
- New bytecodeHash values match the actual deployed bytecode
- Contracts at these addresses have been audited/tested appropriately
- Any dependent systems (indexers, frontends, documentation) are aware of the address change
Before merging, please confirm these details and consider adding deployment notes or a migration guide if users need to perform any actions due to the address change.
Also applies to: 90-93
.github/workflows/fuzz.yml (1)
38-39: Corepack initialization looks good.The
corepack enablecommand is correctly placed after Node.js setup and before yarn invocation, ensuring the appropriate Yarn version (as configured in package.json) is used. This aligns with best practices for modern Node.js tooling..github/workflows/upgrade.yml (1)
40-41: Corepack initialization looks good.The
corepack enablecommand is correctly positioned after Node.js setup and registry configuration, ensuring proper package manager initialization before yarn runs..github/workflows/pr.yml (1)
16-17: Corepack initialization looks good.The
corepack enablestep is correctly placed after Node.js setup and before yarn, following standard best practices..github/workflows/release.yml (1)
34-35: Corepack initialization looks good.The
corepack enablestep is correctly placed after Node.js setup and registry URL configuration, before yarn execution..github/workflows/deploy.yml (1)
40-41: Corepack initialization looks good.The
corepack enablestep is correctly placed after Node.js setup and registry configuration, before yarn execution..github/workflows/prerelease.yml (1)
31-32: Corepack initialization looks good.The
corepack enablestep is correctly placed after Node.js setup and before yarn execution.
Summary by CodeRabbit