Fix React error #31 in skills autocomplete#80
Open
0xabstracted wants to merge 1 commit intomainfrom
Open
Conversation
…omplete) YAML frontmatter fields from skill files can parse as objects instead of strings (e.g. description with nested mappings). The skills API returned these raw values, and the UI rendered them directly as React children, causing "Objects are not valid as a React child" crash. Server: add safeString/safeStringArray helpers to coerce all skill API response fields to proper types. UI: add defensive type checks in useSkillAutocomplete hook, TaskDescriptionField, SkillsPanel, and ClaudeCodeSkillsSelector before rendering skill data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeString()andsafeStringArray()helpers inskillRoutes.tsto sanitize all skill API response fields — YAML frontmatter can produce objects/arrays where strings are expecteduseSkillAutocomplete,TaskDescriptionField,SkillsPanel, andClaudeCodeSkillsSelectorto ensure only strings are rendered as React children/in the task description area to trigger skill autocompleteRoot Cause
Skill YAML frontmatter fields (description, triggers, tags, etc.) can parse as objects instead of strings depending on the YAML structure. The API returned these raw values, and the UI rendered them directly as React children, triggering React error #31: "Objects are not valid as a React child".
Test plan
/in the task description field with Hannibal project skills loaded — should show skill suggestions without crashing🤖 Generated with Claude Code