Fix Resume button not showing for crashed spawned sessions#67
Open
0xabstracted wants to merge 1 commit intomainfrom
Open
Fix Resume button not showing for crashed spawned sessions#670xabstracted wants to merge 1 commit intomainfrom
0xabstracted wants to merge 1 commit intomainfrom
Conversation
When a spawned agent crashes immediately (exit code 1), the pty-exit event
fires before invoke('create_session') returns. At that point the terminal
session isn't in the store yet, so the pty-exit handler can't find the
maestroSessionId and skips the server status update. The server session
stays stuck at 'spawning', which doesn't match the Resume button's
condition of ['completed', 'stopped', 'failed', 'idle'].
Two fixes:
- applyPendingExit now sends status:'stopped' to the maestro server when
consuming a pending exit with a maestroSessionId
- handleSpawnTerminalSession now calls applyPendingExit before adding the
session to the store, catching the race immediately
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invoke('create_session')returns, thepty-exithandler can't find the session in the store yet, so it skips the server status update — leaving the maestro session stuck atspawning['completed', 'stopped', 'failed', 'idle'], sospawningsessions never show itChanges (
useSessionStore.ts)applyPendingExitnow sendsstatus: 'stopped'to the maestro server when consuming a pending exit that has amaestroSessionIdhandleSpawnTerminalSessionnow callsapplyPendingExiton the new session before adding it to the store, catching the race immediatelyTest plan
stopped)🤖 Generated with Claude Code