Skip to content

Markdown comment box with @mentions and review improvements#88

Merged
stylessh merged 2 commits intomainfrom
stylessh/md-comment-box
Apr 13, 2026
Merged

Markdown comment box with @mentions and review improvements#88
stylessh merged 2 commits intomainfrom
stylessh/md-comment-box

Conversation

@stylessh
Copy link
Copy Markdown
Owner

Summary

  • Add reusable MarkdownEditor component with Write/Preview tabs, formatting toolbar, and caret-anchored @mention dropdown with lazy-loaded collaborators (prioritizing involved users)
  • Wire up the Send button on PR/issue comment boxes with createComment server function and proper server-side cache invalidation (D1 + KV namespace bumps)
  • Fix submit review flow: properly await async submission, surface errors via toast, and handle OAuth org access restriction errors with a bottom bar warning instead of oversized toasts
  • Redesign review comment bubbles for tighter styling; add inline edit mode for pending review comments
  • Refactor pull-body-section.tsx to reuse the shared MarkdownEditor, removing ~250 lines of duplicated editor code

Test plan

  • Send a comment on a PR detail page and verify it appears in the timeline immediately
  • Send a comment on an issue detail page and verify it appears
  • Type @ in a comment box and verify mention dropdown appears with involved users first
  • Submit a PR review and verify success/error feedback works correctly
  • Edit a pending review comment inline and verify it updates
  • Test against an org with OAuth app restrictions to verify bottom bar warning

…ndling

- Add reusable MarkdownEditor with Write/Preview tabs, toolbar, and @mention support
- Wire up Send button on PR/issue comment boxes with proper cache invalidation
- Fix submit review flow: async handling, error feedback, and OAuth org restriction warnings
- Add edit mode for pending review comments and redesign comment bubble styling
- Prioritize involved users (author, reviewers, commenters) in mention suggestions
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 13, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
diffkit d95a05d Commit Preview URL

Branch Preview URL
Apr 13 2026, 03:07 AM

@stylessh stylessh merged commit bce0382 into main Apr 13, 2026
4 checks passed
stylessh added a commit that referenced this pull request Apr 18, 2026
* Markdown comment box with @mentions, review fixes, and OAuth error handling

- Add reusable MarkdownEditor with Write/Preview tabs, toolbar, and @mention support
- Wire up Send button on PR/issue comment boxes with proper cache invalidation
- Fix submit review flow: async handling, error feedback, and OAuth org restriction warnings
- Add edit mode for pending review comments and redesign comment bubble styling
- Prioritize involved users (author, reviewers, commenters) in mention suggestions

* Add MarkdownEditor component and caret coordinates utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant