Skip to content

Fix login redirect callback#56

Merged
stylessh merged 1 commit intomainfrom
stylessh/login-redirect
Apr 10, 2026
Merged

Fix login redirect callback#56
stylessh merged 1 commit intomainfrom
stylessh/login-redirect

Conversation

@stylessh
Copy link
Copy Markdown
Owner

@stylessh stylessh commented Apr 10, 2026

Summary

  • Preserve sanitized /login redirect search values through GitHub social sign-in as Better Auth callback URLs.
  • Redirect already-authenticated users away from /login to the requested destination instead of always using /.
  • Add tests for redirect normalization and rejection of unsafe redirect targets.

Tests

  • pnpm --dir apps/dashboard exec biome check src/lib/auth-actions.ts src/lib/auth-redirect.ts src/lib/auth-redirect.test.ts src/routes/login.tsx
  • pnpm --dir apps/dashboard run check-types
  • pnpm --dir apps/dashboard exec vitest run src/lib/auth-redirect.test.ts

@stylessh stylessh merged commit e9266e0 into main Apr 10, 2026
3 of 4 checks passed
stylessh added a commit that referenced this pull request Apr 11, 2026
@stylessh
Add API-backed command palette search (#64)
910b52c 
* Misc UI improvements across dashboard (#55)

- Simplify OG titles to use PR title only (drop "PR #xxx" prefix)
- Extract dynamic tabs into dedicated DashboardTabs component with useScrollShadows hook
- Auto-scroll active tab into view on navigation and keyboard shortcuts
- Prefetch labels/reviewers/teams data on popover trigger hover
- Use icon-to-spinner swap pattern for all action CTAs (merge, update branch, save, submit review)
- Hide description dropdown when no actions are available

* Fix login redirect callback (#56)

* Improve activity feed with timeline events, OAuth auth, and paginated loading (#57)

- Add full timeline event rendering (labels, assignments, reviews, cross-references, state changes, milestones, draft state, renames) interleaved chronologically with comments and commits
- Switch user auth from GitHub App to classic OAuth App for proper scope support, enabling cross-reference visibility across public repos
- Paginate both comments and timeline events on demand instead of loading everything upfront
- Add windowed timeline rendering with progressive load-more for large activity feeds
- Create shared LabelPill component with size variants for consistent label rendering
- Handle GitHub App installation detection gracefully with OAuth tokens

* Misc UI improvements: merged banner, login page, markdown (#58)

* Misc UI changes: merged banner, login cleanup, markdown swap

- Add merged branch banner with delete branch CTA on PR detail page
- Add deleteBranch server function for GitHub API
- Simplify login page: remove features card, use product screenshot
- Switch markdown renderer from react-markdown to @m2d/react-markdown
- Fix participant avatars wrapping in detail sidebar
- Export Delete01Icon from icons package

* Format review-file-diff-block with consistent indentation

* Revert markdown renderer to react-markdown to fix CF build

The @m2d/react-markdown swap caused pnpm to resolve
@tanstack/react-start-rsc@0.0.1 which has a broken import
of @tanstack/start-plugin-core/utils, failing the CF Workers build.

* Switch markdown renderer to @m2d/react-markdown

Replaces react-markdown with @m2d/react-markdown for client-side
memoization. The previous lockfile resolution issue that pulled in
a broken @tanstack/react-start-rsc@0.0.1 is avoided by re-resolving
from a clean base.

* Add mobile-first responsive layout with native bottom nav and drawer patterns (#59)

- Add mobile bottom navigation bar with icon-only nav items and avatar
- Hide desktop-only controls (avatar menu, more button, nav items) on mobile
- Make detail tabs mobile-friendly: inline close button, hidden divider
- Wrap PR/issue titles on mobile instead of truncating
- Reduce page padding on mobile across pulls, issues, reviews, and detail pages
- Hide preview button and timeline guide line on mobile
- Make PR stats bar wrap naturally on small screens
- Add Vaul drawer component for native-feeling mobile interactions
- Convert Dialog to render as bottom drawer on mobile (<768px)
- Convert review page: file sidebar as drawer, submit review as drawer
- Force unified diff style on mobile by hiding split/unified toggle

* Implement hybrid GitHub App access (#60)

* Implement hybrid GitHub App access

* Normalize GitHub App private keys

* Use user auth for pull request bypass

* Check GitHub bypass rules for merges

* Add API-backed command palette search
stylessh added a commit that referenced this pull request Apr 11, 2026
@stylessh
Merge search, sort, and filter work (#68)
e01562a 
* Misc UI improvements across dashboard (#55)

- Simplify OG titles to use PR title only (drop "PR #xxx" prefix)
- Extract dynamic tabs into dedicated DashboardTabs component with useScrollShadows hook
- Auto-scroll active tab into view on navigation and keyboard shortcuts
- Prefetch labels/reviewers/teams data on popover trigger hover
- Use icon-to-spinner swap pattern for all action CTAs (merge, update branch, save, submit review)
- Hide description dropdown when no actions are available

* Fix login redirect callback (#56)

* Improve activity feed with timeline events, OAuth auth, and paginated loading (#57)

- Add full timeline event rendering (labels, assignments, reviews, cross-references, state changes, milestones, draft state, renames) interleaved chronologically with comments and commits
- Switch user auth from GitHub App to classic OAuth App for proper scope support, enabling cross-reference visibility across public repos
- Paginate both comments and timeline events on demand instead of loading everything upfront
- Add windowed timeline rendering with progressive load-more for large activity feeds
- Create shared LabelPill component with size variants for consistent label rendering
- Handle GitHub App installation detection gracefully with OAuth tokens

* Misc UI improvements: merged banner, login page, markdown (#58)

* Misc UI changes: merged banner, login cleanup, markdown swap

- Add merged branch banner with delete branch CTA on PR detail page
- Add deleteBranch server function for GitHub API
- Simplify login page: remove features card, use product screenshot
- Switch markdown renderer from react-markdown to @m2d/react-markdown
- Fix participant avatars wrapping in detail sidebar
- Export Delete01Icon from icons package

* Format review-file-diff-block with consistent indentation

* Revert markdown renderer to react-markdown to fix CF build

The @m2d/react-markdown swap caused pnpm to resolve
@tanstack/react-start-rsc@0.0.1 which has a broken import
of @tanstack/start-plugin-core/utils, failing the CF Workers build.

* Switch markdown renderer to @m2d/react-markdown

Replaces react-markdown with @m2d/react-markdown for client-side
memoization. The previous lockfile resolution issue that pulled in
a broken @tanstack/react-start-rsc@0.0.1 is avoided by re-resolving
from a clean base.

* Add mobile-first responsive layout with native bottom nav and drawer patterns (#59)

- Add mobile bottom navigation bar with icon-only nav items and avatar
- Hide desktop-only controls (avatar menu, more button, nav items) on mobile
- Make detail tabs mobile-friendly: inline close button, hidden divider
- Wrap PR/issue titles on mobile instead of truncating
- Reduce page padding on mobile across pulls, issues, reviews, and detail pages
- Hide preview button and timeline guide line on mobile
- Make PR stats bar wrap naturally on small screens
- Add Vaul drawer component for native-feeling mobile interactions
- Convert Dialog to render as bottom drawer on mobile (<768px)
- Convert review page: file sidebar as drawer, submit review as drawer
- Force unified diff style on mobile by hiding split/unified toggle

* Implement hybrid GitHub App access (#60)

* Implement hybrid GitHub App access

* Normalize GitHub App private keys

* Use user auth for pull request bypass

* Check GitHub bypass rules for merges

* Fix merged PRs showing red closed icon in search-based views (#61)

The GitHub Search API returns merged_at inside pull_request sub-object,
not at the top level. Extract it before passing to mapPullSummary.

* Add search, sort, and filter system for pulls, issues, and reviews pages

Implement a reusable FilterBar component with instant text search, sort dropdown,
and Linear-style two-level filter pills (field picker → value picker) for
Repository, Author, and Status fields. Filter state persists via cookies
read server-side to avoid SSR flash.
stylessh added a commit that referenced this pull request Apr 18, 2026
@stylessh
Add API-backed command palette search (#64)
a56ff19 
* Misc UI improvements across dashboard (#55)

- Simplify OG titles to use PR title only (drop "PR #xxx" prefix)
- Extract dynamic tabs into dedicated DashboardTabs component with useScrollShadows hook
- Auto-scroll active tab into view on navigation and keyboard shortcuts
- Prefetch labels/reviewers/teams data on popover trigger hover
- Use icon-to-spinner swap pattern for all action CTAs (merge, update branch, save, submit review)
- Hide description dropdown when no actions are available

* Fix login redirect callback (#56)

* Improve activity feed with timeline events, OAuth auth, and paginated loading (#57)

- Add full timeline event rendering (labels, assignments, reviews, cross-references, state changes, milestones, draft state, renames) interleaved chronologically with comments and commits
- Switch user auth from GitHub App to classic OAuth App for proper scope support, enabling cross-reference visibility across public repos
- Paginate both comments and timeline events on demand instead of loading everything upfront
- Add windowed timeline rendering with progressive load-more for large activity feeds
- Create shared LabelPill component with size variants for consistent label rendering
- Handle GitHub App installation detection gracefully with OAuth tokens

* Misc UI improvements: merged banner, login page, markdown (#58)

* Misc UI changes: merged banner, login cleanup, markdown swap

- Add merged branch banner with delete branch CTA on PR detail page
- Add deleteBranch server function for GitHub API
- Simplify login page: remove features card, use product screenshot
- Switch markdown renderer from react-markdown to @m2d/react-markdown
- Fix participant avatars wrapping in detail sidebar
- Export Delete01Icon from icons package

* Format review-file-diff-block with consistent indentation

* Revert markdown renderer to react-markdown to fix CF build

The @m2d/react-markdown swap caused pnpm to resolve
@tanstack/react-start-rsc@0.0.1 which has a broken import
of @tanstack/start-plugin-core/utils, failing the CF Workers build.

* Switch markdown renderer to @m2d/react-markdown

Replaces react-markdown with @m2d/react-markdown for client-side
memoization. The previous lockfile resolution issue that pulled in
a broken @tanstack/react-start-rsc@0.0.1 is avoided by re-resolving
from a clean base.

* Add mobile-first responsive layout with native bottom nav and drawer patterns (#59)

- Add mobile bottom navigation bar with icon-only nav items and avatar
- Hide desktop-only controls (avatar menu, more button, nav items) on mobile
- Make detail tabs mobile-friendly: inline close button, hidden divider
- Wrap PR/issue titles on mobile instead of truncating
- Reduce page padding on mobile across pulls, issues, reviews, and detail pages
- Hide preview button and timeline guide line on mobile
- Make PR stats bar wrap naturally on small screens
- Add Vaul drawer component for native-feeling mobile interactions
- Convert Dialog to render as bottom drawer on mobile (<768px)
- Convert review page: file sidebar as drawer, submit review as drawer
- Force unified diff style on mobile by hiding split/unified toggle

* Implement hybrid GitHub App access (#60)

* Implement hybrid GitHub App access

* Normalize GitHub App private keys

* Use user auth for pull request bypass

* Check GitHub bypass rules for merges

* Add API-backed command palette search
stylessh added a commit that referenced this pull request Apr 18, 2026
@stylessh
Merge search, sort, and filter work (#68)
1313753 
* Misc UI improvements across dashboard (#55)

- Simplify OG titles to use PR title only (drop "PR #xxx" prefix)
- Extract dynamic tabs into dedicated DashboardTabs component with useScrollShadows hook
- Auto-scroll active tab into view on navigation and keyboard shortcuts
- Prefetch labels/reviewers/teams data on popover trigger hover
- Use icon-to-spinner swap pattern for all action CTAs (merge, update branch, save, submit review)
- Hide description dropdown when no actions are available

* Fix login redirect callback (#56)

* Improve activity feed with timeline events, OAuth auth, and paginated loading (#57)

- Add full timeline event rendering (labels, assignments, reviews, cross-references, state changes, milestones, draft state, renames) interleaved chronologically with comments and commits
- Switch user auth from GitHub App to classic OAuth App for proper scope support, enabling cross-reference visibility across public repos
- Paginate both comments and timeline events on demand instead of loading everything upfront
- Add windowed timeline rendering with progressive load-more for large activity feeds
- Create shared LabelPill component with size variants for consistent label rendering
- Handle GitHub App installation detection gracefully with OAuth tokens

* Misc UI improvements: merged banner, login page, markdown (#58)

* Misc UI changes: merged banner, login cleanup, markdown swap

- Add merged branch banner with delete branch CTA on PR detail page
- Add deleteBranch server function for GitHub API
- Simplify login page: remove features card, use product screenshot
- Switch markdown renderer from react-markdown to @m2d/react-markdown
- Fix participant avatars wrapping in detail sidebar
- Export Delete01Icon from icons package

* Format review-file-diff-block with consistent indentation

* Revert markdown renderer to react-markdown to fix CF build

The @m2d/react-markdown swap caused pnpm to resolve
@tanstack/react-start-rsc@0.0.1 which has a broken import
of @tanstack/start-plugin-core/utils, failing the CF Workers build.

* Switch markdown renderer to @m2d/react-markdown

Replaces react-markdown with @m2d/react-markdown for client-side
memoization. The previous lockfile resolution issue that pulled in
a broken @tanstack/react-start-rsc@0.0.1 is avoided by re-resolving
from a clean base.

* Add mobile-first responsive layout with native bottom nav and drawer patterns (#59)

- Add mobile bottom navigation bar with icon-only nav items and avatar
- Hide desktop-only controls (avatar menu, more button, nav items) on mobile
- Make detail tabs mobile-friendly: inline close button, hidden divider
- Wrap PR/issue titles on mobile instead of truncating
- Reduce page padding on mobile across pulls, issues, reviews, and detail pages
- Hide preview button and timeline guide line on mobile
- Make PR stats bar wrap naturally on small screens
- Add Vaul drawer component for native-feeling mobile interactions
- Convert Dialog to render as bottom drawer on mobile (<768px)
- Convert review page: file sidebar as drawer, submit review as drawer
- Force unified diff style on mobile by hiding split/unified toggle

* Implement hybrid GitHub App access (#60)

* Implement hybrid GitHub App access

* Normalize GitHub App private keys

* Use user auth for pull request bypass

* Check GitHub bypass rules for merges

* Fix merged PRs showing red closed icon in search-based views (#61)

The GitHub Search API returns merged_at inside pull_request sub-object,
not at the top level. Extract it before passing to mapPullSummary.

* Add search, sort, and filter system for pulls, issues, and reviews pages

Implement a reusable FilterBar component with instant text search, sort dropdown,
and Linear-style two-level filter pills (field picker → value picker) for
Repository, Author, and Status fields. Filter state persists via cookies
read server-side to avoid SSR flash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stylessh