Merged
Conversation
… and sidebar lookups
Contributor
Author
|
Requesting review from @stylessh who has experience with the following files modified in this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted reusable filter logic into a new
filter-helpers.tsmodule to eliminate duplication across issue and pull request filters. Consolidated status filter definitions and simplified filter matching logic using helper functions and metadata constants.Changes
filter-helpers.ts- ExtractedextractRepoOptions(),extractAuthorOptions(),repoFilterDef, andauthorFilterDeffor reuseissueStatus()helper andISSUE_STATUS_METAconstant; removed 86 lines of duplicated codepullStatus()helper andPULL_STATUS_METAconstant; removed 89 lines of duplicated codeuseMemoMaps instead of.find()calls for O(1) accessTest Plan
Screenshots