Skip to content

ci(dashboard): redeploy on UI workspace packages; fix SSR Shiki stub#159

Merged
stylessh merged 1 commit intomainfrom
stylessh/dashboard-deploy-ui-packages-shiki-ssr
Apr 18, 2026
Merged

ci(dashboard): redeploy on UI workspace packages; fix SSR Shiki stub#159
stylessh merged 1 commit intomainfrom
stylessh/dashboard-deploy-ui-packages-shiki-ssr

Conversation

@stylessh
Copy link
Copy Markdown
Owner

@stylessh stylessh commented Apr 18, 2026

Summary

  • Production deploy workflow: add path filters for packages/ui, packages/icons, and packages/typescript-config so dashboard production deploys run when those workspace dependencies change (not only apps/dashboard).
  • Vite SSR: the Shiki stub used for the Cloudflare Worker SSR bundle assumed the main shiki entry. Fine-grained imports (shiki/core, @shikijs/langs/*, @shikijs/themes/*) need matching stub shapes so Rollup can resolve createHighlighterCore and related symbols during the server build.

Test plan

  • pnpm run build in apps/dashboard (SSR step completes without missing cloudflare:workers / Shiki stub errors in your environment).

Summary by CodeRabbit

  • Chores
    • Updated deployment workflow to monitor additional package dependencies for build triggers.
    • Improved build configuration for server-side rendering module handling during the build process.

Trigger production deploy when workspace packages the dashboard depends on
change. Extend the Cloudflare SSR shiki stub for shiki/core and fine-grained
@shikijs/langs and @shikijs/themes imports so Rollup can build server chunks.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f2a34f5-e0dc-42fa-b8d0-4d90640cbb4e

📥 Commits

Reviewing files that changed from the base of the PR and between d7adb0a and 8f91a56.

📒 Files selected for processing (2)
  • .github/workflows/dashboard-deploy-production.yml
  • apps/dashboard/vite.config.ts

📝 Walkthrough

Walkthrough

The PR expands the GitHub Actions deployment trigger to include additional package paths (packages/ui/**, packages/icons/**, packages/typescript-config/**) and refactors the Vite SSR stub plugin to distinguish between multiple Shiki module entrypoints with specialized stub implementations.

Changes

Cohort / File(s) Summary
GitHub Actions Deployment Trigger
.github/workflows/dashboard-deploy-production.yml
Expanded on.push.paths filter to include packages/ui/**, packages/icons/**, and packages/typescript-config/** alongside apps/dashboard/**.
Vite SSR Stub Plugin
apps/dashboard/vite.config.ts
Refactored SSR stub plugin to provide specialized stubs for different Shiki module entrypoints: shiki/core, @shikijs/core, @shikijs/core/* subpaths, @shikijs/langs/*, and @shikijs/themes/*, replacing the previous single generic stub approach with DEFAULT_STUB, CORE_STUB, LANG_STUB, and THEME_STUB constants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stylessh/dashboard-deploy-ui-packages-shiki-ssr

Comment @coderabbitai help to get the list of available commands and usage tips.

@stylessh stylessh merged commit ddfb150 into main Apr 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant