Conversation
Trigger production deploy when workspace packages the dashboard depends on change. Extend the Cloudflare SSR shiki stub for shiki/core and fine-grained @shikijs/langs and @shikijs/themes imports so Rollup can build server chunks.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR expands the GitHub Actions deployment trigger to include additional package paths ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/ui,packages/icons, andpackages/typescript-configso dashboard production deploys run when those workspace dependencies change (not onlyapps/dashboard).shikientry. Fine-grained imports (shiki/core,@shikijs/langs/*,@shikijs/themes/*) need matching stub shapes so Rollup can resolvecreateHighlighterCoreand related symbols during the server build.Test plan
pnpm run buildinapps/dashboard(SSR step completes without missingcloudflare:workers/ Shiki stub errors in your environment).Summary by CodeRabbit