Skip to content

Adding wrangler.jsonc to gitignore#147

Closed
gregor-tokarev wants to merge 7 commits intostylessh:mainfrom
gregor-tokarev:main
Closed

Adding wrangler.jsonc to gitignore#147
gregor-tokarev wants to merge 7 commits intostylessh:mainfrom
gregor-tokarev:main

Conversation

@gregor-tokarev
Copy link
Copy Markdown
Contributor

@gregor-tokarev gregor-tokarev commented Apr 17, 2026

Summary

Adding wrangler.jsonc to gitignore

This file should be in gitignore because it specifies database ids and kv ids. And for every contributor these values will be different, so they shouldn't be in code history

Changes

  • .gitignore(one line)

Summary by CodeRabbit

  • Chores
    • Updated internal configuration identifiers for database and cache service bindings to reflect new resource assignments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request updates Wrangler resource identifiers for the dashboard application and configures Git to ignore the Wrangler configuration file. The database binding ID and two KV namespace identifiers have been modified in the configuration.

Changes

Cohort / File(s) Summary
Git Configuration
.gitignore
Added apps/dashboard/wrangler.jsonc to ignore patterns.
Wrangler Configuration
apps/dashboard/wrangler.jsonc
Updated resource identifiers: D1 database database_id, and KV namespace GITHUB_CACHE_KV id and preview_id values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding wrangler.jsonc to .gitignore, which is the primary focus of the PR.
Description check ✅ Passed The description includes a Summary and Changes section. However, it lacks the Test Plan section and Screenshots section specified in the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant