Skip to content

fix: center loading spinner on /setup page#141

Merged
stylessh merged 1 commit intomainfrom
stylessh/fix-setup-spinner-center
Apr 16, 2026
Merged

fix: center loading spinner on /setup page#141
stylessh merged 1 commit intomainfrom
stylessh/fix-setup-spinner-center

Conversation

@stylessh
Copy link
Copy Markdown
Owner

@stylessh stylessh commented Apr 16, 2026

Summary

The loading spinner on the /setup page was appearing at the top-center of the viewport instead of the center. This happened because the default DashboardContentLoading component uses h-full, which relies on a height-providing parent — present in the protected dashboard layout but not on the standalone setup page.

Changes

  • Added a SetupPageLoading component with min-h-dvh centering as the pendingComponent for the /setup route

Test Plan

  • Navigate to /setup while the loader is pending and confirm the spinner appears centered in the viewport

Screenshots

Before After
Spinner at top-center Spinner at center-center

Summary by CodeRabbit

  • New Features
    • Added a loading indicator to the setup page that displays while the page content is being loaded, improving the user experience during initial load.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 14413a44-9e71-4683-867d-88e663673f5f

📥 Commits

Reviewing files that changed from the base of the PR and between 96314e9 and bb67996.

📒 Files selected for processing (1)
  • apps/dashboard/src/routes/setup.tsx

📝 Walkthrough

Walkthrough

Added a SetupPageLoading component that displays a centered spinning loader icon and configured the /setup route to display this loader as the pendingComponent during route transitions, without modifying existing route logic or page rendering.

Changes

Cohort / File(s) Summary
Setup Route Pending UI
apps/dashboard/src/routes/setup.tsx
Introduced SetupPageLoading component rendering a centered LoaderCircleIcon spinner and added pendingComponent: SetupPageLoading to the route configuration to display loading state during route transitions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stylessh/fix-setup-spinner-center

Comment @coderabbitai help to get the list of available commands and usage tips.

@stylessh stylessh merged commit 4cdd472 into main Apr 16, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant