Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions apps/dashboard/src/components/layouts/dashboard-tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ import { Link, type useRouter, useRouterState } from "@tanstack/react-router";
import { memo, useCallback, useEffect, useRef, useState } from "react";
import { preloadRouteOnce } from "#/lib/route-preload";
import {
isMergedTab,
removeMergedTabs,
removeOtherTabs,
removeTab,
removeTabsToRight,
reorderTabs,
type Tab,
useTabs,
} from "#/lib/tab-store";
Expand Down Expand Up @@ -91,6 +94,7 @@ interface DashboardTabsProps {
export function DashboardTabs({ tabsReady, routerRef }: DashboardTabsProps) {
const openTabs = useTabs();
const pathname = useRouterState({ select: (s) => s.location.pathname });
const dragTabRef = useRef<string | null>(null);
const [contextTab, setContextTab] = useState<{
tab: Tab;
index: number;
Expand All @@ -103,6 +107,29 @@ export function DashboardTabs({ tabsReady, routerRef }: DashboardTabsProps) {
handleWheel,
} = useScrollShadows(openTabs.length);

const handleDragStart = useCallback((id: string) => {
dragTabRef.current = id;
}, []);

const handleDragOver = useCallback(
(targetId: string) => {
const dragId = dragTabRef.current;
if (!dragId || dragId === targetId) return;
const fromIndex = openTabs.findIndex((t) => t.id === dragId);
const toIndex = openTabs.findIndex((t) => t.id === targetId);
if (fromIndex === -1 || toIndex === -1) return;
const next = [...openTabs];
const [moved] = next.splice(fromIndex, 1);
next.splice(toIndex, 0, moved);
reorderTabs(next);
},
[openTabs],
);

const handleDragEnd = useCallback(() => {
dragTabRef.current = null;
}, []);

// biome-ignore lint/correctness/useExhaustiveDependencies: pathname is intentionally used as a trigger to re-run when the route changes
useEffect(() => {
const container = scrollRef.current;
Expand Down Expand Up @@ -151,6 +178,21 @@ export function DashboardTabs({ tabsReady, routerRef }: DashboardTabsProps) {
removeTabsToRight(contextTab.tab.id);
}, [contextTab]);

const handleContextCloseMerged = useCallback(() => {
const activeTabWillClose = openTabs.find(
(t) => pathname === t.url && isMergedTab(t),
);
removeMergedTabs();
if (activeTabWillClose) {
const remaining = openTabs.filter((t) => !isMergedTab(t));
void routerRef.current.navigate({
to: remaining[0]?.url ?? "/",
});
}
}, [openTabs, pathname, routerRef]);

const hasMergedTabs = openTabs.some(isMergedTab);

if (openTabs.length === 0) return null;

return (
Expand Down Expand Up @@ -195,6 +237,9 @@ export function DashboardTabs({ tabsReady, routerRef }: DashboardTabsProps) {
tab={tab}
icon={Icon}
onClose={handleCloseTab}
onDragStart={handleDragStart}
onDragOver={handleDragOver}
onDragEnd={handleDragEnd}
onContextMenu={() => {
setContextTab({ tab, index });
}}
Expand Down Expand Up @@ -224,6 +269,17 @@ export function DashboardTabs({ tabsReady, routerRef }: DashboardTabsProps) {
<ChevronRightIcon size={14} strokeWidth={2} />
Close tabs to the right
</ContextMenuItem>
<ContextMenuItem
onSelect={handleContextCloseMerged}
disabled={!hasMergedTabs}
>
<GitPullRequestIcon
size={14}
strokeWidth={2}
className="text-purple-500"
/>
Close merged
</ContextMenuItem>
</ContextMenuContent>
</ContextMenu>
</div>
Expand All @@ -234,12 +290,18 @@ const DetailTab = memo(function DetailTab({
tab,
icon: Icon,
onClose,
onDragStart,
onDragOver,
onDragEnd,
onContextMenu,
routerRef,
}: {
tab: Tab;
icon: typeof GitPullRequestIcon;
onClose: (id: string, tabUrl: string) => void;
onDragStart: (id: string) => void;
onDragOver: (id: string) => void;
onDragEnd: () => void;
onContextMenu: () => void;
routerRef: React.RefObject<ReturnType<typeof useRouter>>;
}) {
Expand All @@ -250,6 +312,17 @@ const DetailTab = memo(function DetailTab({
return (
<Link
to={tab.url}
draggable
onDragStart={(e) => {
e.dataTransfer.effectAllowed = "move";
onDragStart(tab.id);
}}
onDragOver={(e) => {
e.preventDefault();
e.dataTransfer.dropEffect = "move";
onDragOver(tab.id);
}}
onDragEnd={onDragEnd}
preload={false}
onMouseEnter={preloadTab}
onFocus={preloadTab}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export function PullDetailContent({
url: `/${owner}/${repo}/pull/${pullNumber}`,
repo: `${owner}/${repo}`,
iconColor: getPrStateConfig(pr).color,
merged: pr.isMerged,
}
: null,
);
Expand Down
1 change: 1 addition & 0 deletions apps/dashboard/src/components/pulls/review/review-page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ export function ReviewPage() {
iconColor: getPrStateConfig(pr).color,
additions: pr.additions,
deletions: pr.deletions,
merged: pr.isMerged,
}
: null,
);
Expand Down
24 changes: 23 additions & 1 deletion apps/dashboard/src/lib/tab-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface Tab {
avatarUrl?: string;
additions?: number;
deletions?: number;
merged?: boolean;
}

export const TABS_STORAGE_KEY = "diffkit:tabs";
Expand Down Expand Up @@ -88,7 +89,8 @@ export function addTab(tab: Tab) {
existing.title === tab.title &&
existing.iconColor === tab.iconColor &&
existing.additions === tab.additions &&
existing.deletions === tab.deletions
existing.deletions === tab.deletions &&
existing.merged === tab.merged
)
return;
tabs = tabs.map((t) => (t.id === tab.id ? tab : t));
Expand Down Expand Up @@ -116,6 +118,26 @@ export function removeTabsToRight(id: string) {
emitChange();
}

export function isMergedTab(t: Tab): boolean {
return (
t.merged === true ||
((t.type === "pull" || t.type === "review") &&
t.iconColor === "text-purple-500")
);
}

export function removeMergedTabs() {
const next = tabs.filter((t) => !isMergedTab(t));
if (next.length === tabs.length) return;
tabs = next;
emitChange();
}

export function reorderTabs(newOrder: Tab[]) {
tabs = newOrder;
emitChange();
}

const emptyTabs: Tab[] = [];

export function useTabs() {
Expand Down
3 changes: 3 additions & 0 deletions apps/dashboard/src/lib/use-register-tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export function useRegisterTab(
avatarUrl?: string;
additions?: number;
deletions?: number;
merged?: boolean;
} | null,
) {
useEffect(() => {
Expand All @@ -31,6 +32,7 @@ export function useRegisterTab(
avatarUrl: tab.avatarUrl,
additions: tab.additions,
deletions: tab.deletions,
merged: tab.merged,
});
}, [
tab?.type,
Expand All @@ -42,5 +44,6 @@ export function useRegisterTab(
tab?.avatarUrl,
tab?.additions,
tab?.deletions,
tab?.merged,
]);
}
Loading