Improve pull request status display and filtering

[premsathisha]

Summary

This PR makes pull request status handling accurate across DiffKit:

• Loads all pull states: Pull request queues now include open, draft, merged, and closed pull requests instead of being limited to open pulls.
• Improves status filtering: The Status filter now consistently supports Open, Draft, Merged, and Closed across global pull queues and repository pull lists.
• Updates tab status display: Pull request tabs now carry real status metadata and use the correct icon for open, draft, merged, and closed pull requests.
• Fixes count wording: The Pull Requests heading no longer describes every listed pull request as open.
• Cleans up filter selection UI: Selected filter values now use a right-aligned checkmark instead of a boxed checkbox treatment.

Before

• Pull request search was built around open pull requests only.
• The Pull Requests heading said open pulls across your queues, which became incorrect once non-open pull requests were shown.
• Tabs could not directly tell whether a pull request was open, draft, merged, or closed.
• Filter selections used heavier boxed checkmarks inside compact menus.

After

• Pull request queues can show open, draft, merged, and closed pull requests.
• Status filters work consistently across pull request views.
• Tabs use status-specific icons based on actual pull request state.
• The Pull Requests heading describes the count as pulls across your queues.
• Filter menus are easier to scan with cleaner selected-state styling.

Validation

• pnpm --filter @diffkit/dashboard check
• pnpm --filter @diffkit/dashboard check-types
• pnpm --filter @diffkit/dashboard build

Summary by CodeRabbit

• New Features

  • Pull request tabs now display state-specific icons reflecting their current status (draft, merged, closed, or open).

• Improvements

  • Search now includes all pull request states, not just open ones.
  • Enhanced pull request state tracking across the dashboard.

• Style

  • Updated filter selection visual display.
  • Refined pulls page summary text.

[premsathisha]

[stylessh]

can you resolve conflicts

[coderabbitai]

Warning

Rate limit exceeded

@premsathisha has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 19 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 19 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7c630362-463b-466a-92de-f6e5019542c6

📥 Commits

Reviewing files that changed from the base of the PR and between abbce3f and d6f6c6e.

📒 Files selected for processing (2)

• apps/dashboard/src/lib/github.functions.ts
• apps/dashboard/src/lib/tab-store.ts

📝 Walkthrough

Walkthrough

The changes introduce pull-request state tracking (draft/open/closed/merged) across the dashboard's UI and data-fetching layers. Pull state is derived from PR properties, propagated through tab registration, and used for icon selection. A shared status filter configuration consolidates duplicated filter logic. Search queries now include non-open pull states, and tab state management is extended to support the new pullState field.

Changes

Cohort / File(s)	Summary
Pull State Tracking apps/dashboard/src/components/pulls/detail/pull-detail-page.tsx, apps/dashboard/src/components/pulls/review/review-page.tsx, apps/dashboard/src/components/layouts/dashboard-tabs.tsx	Introduces pull-state derivation (draft/merged/closed/open) from PR properties or tab metadata, and uses it for tab registration and icon selection logic.
Tab State Management apps/dashboard/src/lib/tab-store.ts, apps/dashboard/src/lib/use-register-tab.ts	Extends Tab interface with optional pullState field and updates tab registration hook to include and track this field.
Status Filter Consolidation apps/dashboard/src/components/filters/pull-filters.ts	Introduces shared pull-status configuration and helper functions (getPullStatusFilterOptions(), matchPullStatus()), refactoring duplicate status-filter logic in both pullFilterDefs and repoPullFilterDefs.
Data Fetching Updates apps/dashboard/src/lib/github.functions.ts	Adds mergeCachedMyPullsResult() function and changes PR search queries from state: "open" to state: "all", affecting result caching and shape.
UI Component Updates apps/dashboard/src/components/filters/filter-bar.tsx	Refactors option-row rendering to replace bordered checkmark container with inline CheckIcon positioned at right when selected.
UI Text Updates apps/dashboard/src/routes/_protected/pulls.tsx	Changes summary text from "{totalPulls} open pulls across your queues" to "{totalPulls} pulls across your queues".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Improve pull request status display and filtering' clearly and specifically summarizes the main changes across the changeset.
Description check	✅ Passed	The PR description is comprehensive and well-structured, covering summary, before/after context, and validation steps, meeting the repository's template requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

apps/dashboard/src/components/filters/filter-bar.tsx (1)

440-457: ⚠️ Potential issue | 🟠 Major

Expose selected state to assistive technology on toggle options.

Line 440 and Line 511 render selection state only visually (color + check icon). Screen readers won’t reliably get the selected/unselected state for these toggle buttons.

♿ Minimal fix

@@
 						<button
 							key={opt.value}
 							type="button"
 							onClick={() => onToggle(opt.value)}
+							aria-pressed={isSelected}
 							className={cn(
 								"flex items-center gap-2 rounded-md px-2.5 py-1.5 text-left text-sm transition-colors hover:bg-surface-2",
 								isSelected && "text-foreground",
 							)}
 						>
@@
 						<button
 							key={opt.value}
 							type="button"
 							onClick={() => onToggle(opt.value)}
+							aria-pressed={isSelected}
 							className={cn(
 								"flex items-center gap-2 rounded-md px-2.5 py-1.5 text-left text-sm transition-colors hover:bg-surface-2",
 								isSelected && "text-foreground",
 							)}
 						>

Also applies to: 511-528

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/components/filters/filter-bar.tsx` around lines 440 - 457,
The toggle option buttons only convey selection visually; update the button
elements in filter-bar.tsx (the button that calls onToggle(opt.value) and the
similar button around lines ~511) to expose state to assistive tech by adding
aria-pressed={isSelected} (or aria-checked if you prefer
role="checkbox"/"menuitemcheckbox" semantics) so screen readers announce
selected/unselected; keep existing visuals and onClick behavior unchanged and
apply the same attribute to both occurrences where the option button is
rendered.

🧹 Nitpick comments (1)

apps/dashboard/src/components/filters/pull-filters.ts (1)

51-56: Reuse this resolver everywhere PR status is derived.

apps/dashboard/src/components/pulls/detail/pull-detail-page.tsx:119-127 still computes status inline with a different precedence (draft before closed/merged). That can make a PR’s displayed status diverge from how this filter classifies it on edge states. Export the shared resolver/type from here and consume it there so the UI and filters stay in sync.

♻️ Suggested direction

+export type PullStatus = (typeof pullStatusFilterOptions)[number]["value"];
-
-function getPullStatusValue(pull: PullFilterableItem) {
+export function getPullStatusValue(pull: PullFilterableItem): PullStatus {
 	if (pull.mergedAt || pull.state === "merged") return "merged";
 	if (pull.state === "closed") return "closed";
 	if (pull.isDraft) return "draft";
 	return "open";
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/dashboard/src/components/filters/pull-filters.ts` around lines 51 - 56,
Export the shared resolver and its input type from this module (export
getPullStatusValue and the PullFilterableItem/related type) and update the other
usage in pull-detail-page.tsx to import and call getPullStatusValue instead of
computing status inline; ensure the exported resolver preserves the intended
precedence (merged → closed → draft → open) so UI and filters stay in sync.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/dashboard/src/lib/github.functions.ts`:
- Around line 4227-4239: The mergeCachedMyPullsResult function currently
overwrites existing partial-result warnings with only fresh.forbiddenOrgs and
fresh.timedOut, which can drop prior warnings; change the merge so when fresh is
partial (i.e., fresh.timedOut or fresh.forbiddenOrgs non-empty) you still merge
bucket data via mergeMyPullsResults([existing, fresh]) but set forbiddenOrgs to
the union of existing.forbiddenOrgs and fresh.forbiddenOrgs (deduplicated) and
set timedOut to existing.timedOut || fresh.timedOut so any prior warning state
is preserved; keep the early return for the fully fresh case.

In `@apps/dashboard/src/lib/tab-store.ts`:
- Line 13: The isMergedTab() logic should be updated to honor the new pullState
metadata: change its checks so it returns true when tab.pullState === "merged"
(in addition to retaining backward-compatible checks for the legacy merged
boolean or iconColor if you want), and update any other places that determine
merged-tabs (e.g., the handler referenced around the other occurrence) to rely
on pullState instead of only checking merged or iconColor; modify the Tab type
usages and the functions isMergedTab() and the other referenced conditional
(near the second occurrence) to prefer pullState === "merged" as the canonical
source of truth while keeping legacy checks for compatibility.

---

Outside diff comments:
In `@apps/dashboard/src/components/filters/filter-bar.tsx`:
- Around line 440-457: The toggle option buttons only convey selection visually;
update the button elements in filter-bar.tsx (the button that calls
onToggle(opt.value) and the similar button around lines ~511) to expose state to
assistive tech by adding aria-pressed={isSelected} (or aria-checked if you
prefer role="checkbox"/"menuitemcheckbox" semantics) so screen readers announce
selected/unselected; keep existing visuals and onClick behavior unchanged and
apply the same attribute to both occurrences where the option button is
rendered.

---

Nitpick comments:
In `@apps/dashboard/src/components/filters/pull-filters.ts`:
- Around line 51-56: Export the shared resolver and its input type from this
module (export getPullStatusValue and the PullFilterableItem/related type) and
update the other usage in pull-detail-page.tsx to import and call
getPullStatusValue instead of computing status inline; ensure the exported
resolver preserves the intended precedence (merged → closed → draft → open) so
UI and filters stay in sync.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ca8795ac-4b6d-4ed6-bdf6-701a31d65407

📥 Commits

Reviewing files that changed from the base of the PR and between ce9a5a8 and abbce3f.

📒 Files selected for processing (9)

• apps/dashboard/src/components/filters/filter-bar.tsx
• apps/dashboard/src/components/filters/pull-filters.ts
• apps/dashboard/src/components/layouts/dashboard-tabs.tsx
• apps/dashboard/src/components/pulls/detail/pull-detail-page.tsx
• apps/dashboard/src/components/pulls/review/review-page.tsx
• apps/dashboard/src/lib/github.functions.ts
• apps/dashboard/src/lib/tab-store.ts
• apps/dashboard/src/lib/use-register-tab.ts
• apps/dashboard/src/routes/_protected/pulls.tsx