Improve search preload and cache reliability

[premsathisha]

Summary

This PR improves DiffKit search, issue navigation preload, and local GitHub cache reliability:

• Ticket number search: Lets list search match ticket numbers directly, so queries like 124 and #124 can find matching issue or pull request rows.
• Issue-row preload: Preloads issue detail routes when an issue row is hovered, focused, or touched.
• GitHub cache freshness: Improves GitHub signal polling so locally cached data is invalidated when a missed signal is newer than the local query data.
• Cache version reset: Bumps the persisted GitHub query cache key so older cached payloads do not keep stale data around after the cache behavior changed.
• Storage-full protection: Protects query-cache persistence when browser storage is unavailable or full by disabling persistence for the rest of the session instead of breaking the app.

Why

• Search: Searching by ticket number is a common workflow, but the shared list search only matched title, repository, and author text. Numeric issue and pull request identifiers are now first-class searchable fields.
• Navigation speed: Issue rows also needed the same fast-open path as other detail rows. Preloading the detail route on intent reduces the wait after selecting an issue without loading every issue detail upfront.
• Reliability: The GitHub cache changes reduce the chance of showing old data after reloads or missed update signals, while the storage guard keeps the UI usable if localStorage writes fail because browser storage is full, blocked, or unavailable.

Validation

• pnpm --filter @diffkit/dashboard check
• pnpm --filter @diffkit/dashboard check-types
• pnpm --filter @diffkit/dashboard build

Summary by CodeRabbit

• New Features

  • Numeric filtering with hash-prefix syntax (e.g., #123) and improved deduplication of search results before sorting.

• Bug Fixes

  • Cache persistence now fails gracefully and disables further persistence after storage errors.
  • Signal-stream handling improved with stale-data detection and deduplication of updated keys.
  • Route preloading now occurs on user intent (hover, focus, touch) instead of automatic preloads.

• Style

  • Adjusted command palette spacing and item rounding for improved layout.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ae595db7-8715-40bb-ae3f-fc4a0c90ac72

📥 Commits

Reviewing files that changed from the base of the PR and between 8df1955 and b5629b9.

📒 Files selected for processing (1)

• apps/dashboard/src/components/filters/use-list-filters.ts

---

📝 Walkthrough

Walkthrough

Adds numeric (#-prefixed) search support to list filtering, changes issue-link preloading to explicit user-intent-driven preloads, makes React Query cache persistence resilient to storage errors by disabling writes for the session on failure, refines signal-stream polling to ignore newer local data and deduplicate missed keys, and tweaks Command palette padding and item rounding.

Changes

Cohort / File(s)	Summary
List Filtering Enhancement apps/dashboard/src/components/filters/use-list-filters.ts	Added optional number?: number to FilterableItem. applyFilters now normalizes queries starting with #, detects fully-numeric queries, matches numeric items by prefix when applicable, and deduplicates filtered results by item.id before sorting.
Issue Row Preloading apps/dashboard/src/components/issues/issue-row.tsx	Imported useRouter and preloadRouteOnce; disabled automatic Link preloading (preload={false}) and added explicit preloadDetail triggered on onMouseEnter, onFocus, and onTouchStart, with error logging.
Query Cache Persistence apps/dashboard/src/lib/query-client.tsx	Inside persistGitHubQueryCache introduced session-scoped persistenceDisabled flag; writeCache, scheduleWrite, and flushOnUnload early-return when disabled. Wrapped dehydrate/localStorage writes in try/catch to remove cached key and disable further persistence on error.
Signal Stream Polling apps/dashboard/src/lib/use-github-signal-stream.ts	Added hasStaleLocalDataForSignal to check dataUpdatedAt against incoming signal.updatedAt; treat first-seen signal keys as missed only if local data is stale/missing. Switched updatedKeys from array to Set for deduplication and adjusted logging/invalidation call sites.
Command Palette Styling packages/ui/src/components/command.tsx	Adjusted Tailwind classes: increased horizontal padding from px-2 to px-3 on container descendant selector and CommandItem, and added rounded-sm to items; preserved selection/disabled, layout, and icon sizing behaviors.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the three primary changes: search improvements, preload optimization, and cache reliability enhancements.
Description check	✅ Passed	The description covers all required template sections with comprehensive details: Summary explains each change with context, Changes section lists five specific improvements, Validation section includes test commands run, and Test Plan is marked complete.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/dashboard/src/components/filters/use-list-filters.ts`:
- Around line 246-265: The current filter branch for isHashNumberQuery is
exclusive and treats a bare "#" as matching everything; change it so
ticket-number matching is additive to the normal text checks: inside the
result.filter where isHashNumberQuery is used, only treat it as a ticket-number
check when normalizedNumberQuery is non-empty and isNumericQuery is true,
otherwise fall back to the same text checks used in the else branch; when
normalizedNumberQuery is present, return true if either the text checks
(item.title, item.repository.fullName, item.author?.login) match OR the number
check (typeof item.number === "number" &&
String(item.number).startsWith(normalizedNumberQuery)) matches so ticket
searches are additive rather than exclusive.

In `@apps/dashboard/src/components/issues/issue-row.tsx`:
- Around line 27-29: The preloadDetail handler currently discards the promise
from preloadRouteOnce(router, href) causing potential unhandled rejections;
update preloadDetail to explicitly handle errors from preloadRouteOnce(router,
href) (either by making preloadDetail async and using try/catch around await
preloadRouteOnce(...) or by attaching .catch(...) to the returned promise) and
surface the error (e.g., console.error or the app logger) so loader/network
failures are not left unhandled.

In `@apps/dashboard/src/lib/query-client.tsx`:
- Around line 212-218: When localStorage.setItem in the persistence block fails,
remove the stale entry under GITHUB_QUERY_CACHE_STORAGE_KEY before disabling
persistence so old cache won't be rehydrated; update the catch in the same block
(where persistenceDisabled is set) to perform a best-effort
window.localStorage.removeItem(GITHUB_QUERY_CACHE_STORAGE_KEY) (silently ignore
errors) and then set persistenceDisabled = true so the code in this module
(query-client.tsx) no longer persists or rehydrates the stale payload.

In `@apps/dashboard/src/lib/use-github-signal-stream.ts`:
- Around line 83-107: getLatestLocalDataTimestampForSignal currently returns the
max dataUpdatedAt across targets which hides stale targets; change it to detect
"any stale target" instead: update getLatestLocalDataTimestampForSignal to
iterate matching targets and return a boolean (e.g., hasAnyStaleLocalData) that
is true if any target has no queryState or queryState.dataUpdatedAt <
signal.updatedAt, and false otherwise, then update callers that used the
timestamp to use this boolean to add updatedKeys when any target is stale; apply
the same change to the other identical block referenced in the comment.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dea214d0-6c7a-4d74-b5de-a564d8d495e3

📥 Commits

Reviewing files that changed from the base of the PR and between 134ab04 and 71d4d2c.

📒 Files selected for processing (4)

• apps/dashboard/src/components/filters/use-list-filters.ts
• apps/dashboard/src/components/issues/issue-row.tsx
• apps/dashboard/src/lib/query-client.tsx
• apps/dashboard/src/lib/use-github-signal-stream.ts

[stylessh]

some items are being duplicated on search.

[premsathisha]

some items are being duplicated on search.

Fixed now