Fix LFS README image assets#113
Merged
stylessh merged 1 commit intostylessh:mainfrom Apr 14, 2026
Merged
Conversation
stylessh
reviewed
Apr 14, 2026
| } | ||
|
|
||
| const rootUrl = `https://raw.githubusercontent.com/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/${encodePath(ref)}/`; | ||
| const rootUrl = `https://github.com/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/raw/${encodePath(ref)}/`; |
Owner
There was a problem hiding this comment.
does this support all the other images urls?
stylessh
approved these changes
Apr 14, 2026
stylessh
pushed a commit
that referenced
this pull request
Apr 18, 2026
Co-authored-by: Prem Sathisha Etagi <premsathisha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix README image rendering for repository assets stored with Git LFS. The previous resolver pointed relative README images directly at
raw.githubusercontent.com, which returns the LFS pointer text for LFS-backed files instead of the actual image. Using GitHub's/raw/route lets GitHub redirect normal files toraw.githubusercontent.comand LFS files tomedia.githubusercontent.com.Changes
github.com/{owner}/{repo}/raw/{ref}/...penso/arborLFS screenshot case and existing relative path behaviorTest Plan
pnpm --filter dashboard exec vitest run src/components/repo/repo-markdown-files.test.tspnpm --filter dashboard check-typespnpm exec biome check apps/dashboard/src/components/repo/repo-markdown-files.tsx apps/dashboard/src/components/repo/repo-markdown-files.test.tspnpm --filter dashboard buildhttps://github.com/penso/arbor/raw/main/assets/screenshot.pngredirects tomedia.githubusercontent.comraw.githubusercontent.comScreenshots
No UI layout change; this only changes how relative README image asset URLs are resolved.