Fix quick scans for working tree and non-ASCII paths#99
Merged
study8677 merged 1 commit intoJul 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
quick_scan()compared the last refresh SHA only withHEAD, so staged and unstaged edits were silently missed. Git also quoted non-ASCII filenames in line-delimited output, causing those paths to be joined to files that do not exist. Nested workspaces could receive repository-root-relative paths, and rename detection hid the old path.Validation
python -X utf8 scripts/check_repo_contract.pypython -X utf8 -m pytest engine/tests/test_hub_scanner.py -q— 32 passedpython -X utf8 -m pytest engine/tests cli/tests -q -k "not test_mcp_log_permissions_are_private"— 280 passed, 1 deselectedThe unfiltered Windows run reached 280 passed with one existing POSIX permission-mode assertion failing because Windows does not expose Unix chmod bits.