feat: CI 追加#3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds comprehensive CI/CD infrastructure and standardizes code formatting/linting across both frontend and backend codebases. The PR introduces automated checks for linting, formatting, type checking, and testing through GitHub Actions workflows.
Changes:
- Added GitHub Actions workflow for automated code quality checks (lint, format, type-check, test)
- Configured Prettier for frontend formatting (no semicolons, single quotes, 100 char width)
- Configured Ruff and mypy for backend linting and strict type checking
- Applied formatting changes across all TypeScript/React and Python files
- Updated type annotations to use modern Python 3.10+ syntax (union types, StrEnum, UTC)
- Added new npm scripts for formatting and type checking
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/check.yml | New CI workflow with 7 jobs for frontend/backend lint, format, typecheck, and test |
| frontend/package.json | Added Prettier dependency and format/type-check scripts |
| frontend/.prettierrc | Prettier configuration: no semicolons, single quotes, trailing commas |
| frontend/.prettierignore | Exclude dist, node_modules, package-lock.json from formatting |
| frontend/package-lock.json | Added Prettier 3.8.1 dependency |
| frontend/vite.config.ts | Fixed trailing comma formatting |
| frontend/tsconfig.json | Collapsed multi-line references array to single line |
| frontend/src/**/*.ts(x) | Applied Prettier formatting: removed semicolons, adjusted line breaks |
| backend/pyproject.toml | Added Ruff and mypy configuration with strict type checking |
| backend/uv.lock | Added ruff, mypy, and dependencies (librt, mypy-extensions, pathspec) |
| backend/app/**/*.py | Applied Ruff formatting, updated to modern type syntax (X | None, StrEnum, UTC) |
| backend/app/model/base.py | Added allow_unmapped = True for SQLAlchemy 2.0 compatibility |
| backend/tests/**/*.py | Applied formatting, updated Generator type hints |
| backend/migration/env.py | Reorganized imports per Ruff isort rules |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.