Skip to content

Fix command injection vulnerability in grep_processes endpoint #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
studentsca023-rgb merged 2 commits into from
Mar 17, 2026
Merged

Fix command injection vulnerability in grep_processes endpoint #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48beee5
Fix command injection vulnerability in grep_processes endpoint
Mar 17, 2026
6b20d00
Merge branch 'master' into semgrep-autofix/1773733105
studentsca023-rgb Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions flask_webgoat/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,18 @@ def grep_processes():
)
if res.stdout is None:
return jsonify({"error": "no stdout returned"})

out = res.stdout.decode("utf-8")
lines = out.split("\n")
# Filter lines containing the name and extract the 11th field (command)

# Filter lines containing the name and extract the 11th column (command)
names = []
for line in lines:
if name and name in line:
if name in line:
parts = line.split()
if len(parts) >= 11:
names.append(parts[10]) # 0-indexed, so field 11 is index 10
names.append(parts[10]) # 0-indexed, so 11th column is index 10

return jsonify({"success": True, "names": names})


Expand Down
Loading