Skip to content

Fix insecure deserialization vulnerability by replacing pickle with JSON #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
studentsca023-rgb merged 1 commit into from
Mar 17, 2026
Merged

Fix insecure deserialization vulnerability by replacing pickle with JSON #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions flask_webgoat/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import pickle
import json
import base64
from pathlib import Path
import subprocess
Expand Down Expand Up @@ -55,8 +55,7 @@ def grep_processes():

@bp.route("/deserialized_descr", methods=["POST"])
def deserialized_descr():
pickled = request.form.get('pickled')
data = base64.urlsafe_b64decode(pickled)
# vulnerability: Insecure Deserialization
deserialized = pickle.loads(data)
encoded = request.form.get('pickled')
data = base64.urlsafe_b64decode(encoded)
deserialized = json.loads(data.decode('utf-8'))
return jsonify({"success": True, "description": str(deserialized)})
Loading