Skip to content

Fix open redirect vulnerability in login_and_redirect endpoint #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
studentsca023-rgb merged 1 commit into from
Mar 17, 2026
Merged

Fix open redirect vulnerability in login_and_redirect endpoint #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions flask_webgoat/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,16 @@ def login_and_redirect():
400,
)

parsed = urlparse(url)
if parsed.netloc or parsed.scheme:
return jsonify({"error": "Invalid redirect URL"}), 400
safe_url = parsed.path
if parsed.query:
safe_url = f"{safe_url}?{parsed.query}"

query = "SELECT id, username, access_level FROM user WHERE username = ? AND password = ?"
result = query_db(query, (username, password), True)
if result is None:
if not is_safe_url(url):
return jsonify({"error": "Invalid redirect URL"}), 400
return redirect(url)
return redirect(safe_url)
session["user_info"] = (result[0], result[1], result[2])
return jsonify({"success": True})
Loading