Suppress false positive SQL injection warning in users.py#15
Merged
Conversation
Suppress false positive Semgrep finding for SQL injection in user registration. ## Changes - Added `# nosemgrep` comment to suppress the tainted-sql-string rule on line 38 of `flask_webgoat/users.py` ## Why The flagged code already uses parameterized queries correctly with `?` placeholders: ```python query = "INSERT INTO user (username, password, access_level) VALUES (?, ?, ?)" query_db(query, [username, password, int(access_level)], False, True) ``` User input values are passed as a separate list to `query_db`, not concatenated into the query string. This is the standard and secure approach to prevent SQL injection. Semgrep cannot trace through to confirm that `query_db` handles parameters safely, resulting in a false positive. ## Semgrep Finding Details Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using an object-relational mapper (ORM) such as SQLAlchemy which will protect your queries. @267212124 requested Semgrep Assistant generate this pull request to fix [a finding](https://semgrep.dev/orgs/studentsca023_personal_org/findings/722169006) from the detection rule [python.flask.security.injection.tainted-sql-string.tainted-sql-string](https://semgrep.dev/r/python.flask.security.injection.tainted-sql-string.tainted-sql-string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress false positive Semgrep finding for SQL injection in user registration.
Changes
# nosemgrepcomment to suppress the tainted-sql-string rule on line 38 offlask_webgoat/users.pyWhy
The flagged code already uses parameterized queries correctly with
?placeholders:User input values are passed as a separate list to
query_db, not concatenated into the query string. This is the standard and secure approach to prevent SQL injection. Semgrep cannot trace through to confirm thatquery_dbhandles parameters safely, resulting in a false positive.Semgrep Finding Details
Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using an object-relational mapper (ORM) such as SQLAlchemy which will protect your queries.
@267212124 requested Semgrep Assistant generate this pull request to fix a finding from the detection rule python.flask.security.injection.tainted-sql-string.tainted-sql-string.