Suppress false positive SQL injection finding in users.py#14
Merged
Conversation
Add nosemgrep comment to suppress false positive SQL injection warning in the user creation endpoint. ## Changes - Added `# nosemgrep` comment to line 38 in `flask_webgoat/users.py` ## Why The code was already using parameterized queries correctly: - The query uses `?` placeholders: `"INSERT INTO user (username, password, access_level) VALUES (?, ?, ?)"` - User input is passed as separate arguments to `query_db()`, which executes via `cursor().execute(query, args)` - This is the secure pattern recommended by SQLite and prevents SQL injection The Semgrep rule flagged this as a false positive because it detected user input variables near a SQL query, but did not recognize that the parameterization was already being handled correctly. ## Semgrep Finding Details Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using an object-relational mapper (ORM) such as SQLAlchemy which will protect your queries. @267212124 requested Semgrep Assistant generate this pull request to fix [a finding](https://semgrep.dev/orgs/studentsca023_personal_org/findings/722169006) from the detection rule [python.flask.security.injection.tainted-sql-string.tainted-sql-string](https://semgrep.dev/r/python.flask.security.injection.tainted-sql-string.tainted-sql-string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nosemgrep comment to suppress false positive SQL injection warning in the user creation endpoint.
Changes
# nosemgrepcomment to line 38 inflask_webgoat/users.pyWhy
The code was already using parameterized queries correctly:
?placeholders:"INSERT INTO user (username, password, access_level) VALUES (?, ?, ?)"query_db(), which executes viacursor().execute(query, args)The Semgrep rule flagged this as a false positive because it detected user input variables near a SQL query, but did not recognize that the parameterization was already being handled correctly.
Semgrep Finding Details
Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using an object-relational mapper (ORM) such as SQLAlchemy which will protect your queries.
@267212124 requested Semgrep Assistant generate this pull request to fix a finding from the detection rule python.flask.security.injection.tainted-sql-string.tainted-sql-string.