Fix SQL injection vulnerability in user registration#12
Merged
Conversation
Fix SQL injection vulnerability in `flask_webgoat/users.py` by replacing string formatting with parameterized queries. ## Changes - Replaced manual SQL string construction using `%` formatting with parameterized query placeholders (`?`) - Passed user inputs (`username`, `password`, `access_level`) as parameters to `query_db` instead of embedding them directly in the query string ## Why The original code used string formatting to construct the SQL INSERT statement, which allowed user-controlled input to be directly interpolated into the query. This created a SQL injection vulnerability where an attacker could manipulate the query structure by providing malicious input values. By using parameterized queries, the database driver handles proper escaping and keeps user data separate from the SQL command structure, preventing injection attacks. ## Semgrep Finding Details Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using the Django object-relational mappers (ORM) instead of raw SQL queries. @267212124 requested Semgrep Assistant generate this pull request to fix [a finding](https://semgrep.dev/orgs/studentsca023_personal_org/findings/722169013) from the detection rule [python.django.security.injection.tainted-sql-string.tainted-sql-string](https://semgrep.dev/r/python.django.security.injection.tainted-sql-string.tainted-sql-string).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SQL injection vulnerability in
flask_webgoat/users.pyby replacing string formatting with parameterized queries.Changes
%formatting with parameterized query placeholders (?)username,password,access_level) as parameters toquery_dbinstead of embedding them directly in the query stringWhy
The original code used string formatting to construct the SQL INSERT statement, which allowed user-controlled input to be directly interpolated into the query. This created a SQL injection vulnerability where an attacker could manipulate the query structure by providing malicious input values.
By using parameterized queries, the database driver handles proper escaping and keeps user data separate from the SQL command structure, preventing injection attacks.
Semgrep Finding Details
Detected user input used to manually construct a SQL string. This is usually bad practice because manual construction could accidentally result in a SQL injection. An attacker could use a SQL injection to steal or modify contents of the database. Instead, use a parameterized query which is available by default in most database engines. Alternatively, consider using the Django object-relational mappers (ORM) instead of raw SQL queries.
@267212124 requested Semgrep Assistant generate this pull request to fix a finding from the detection rule python.django.security.injection.tainted-sql-string.tainted-sql-string.