⚠️ Use HTTP status code in V2 errors #2131
Open
+420
−96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We did an audit of V2 error-handling across our SDKs, and realized that in V2 APIs, Java users do not get typed exceptions based on HTTP Status Code like they do when calling a V1 API. E.g. a
429response code from Stripe in V1 throws aRateLimitException, but against a V2 API, it will throw a more genericApiException. Also, as part of our audit, we decided that it makes more sense to makeRateLimitExceptionextendStripeExceptionrather thanApiException(since it does not come explicitly from the Stripe API). The reason it extendsApiExceptionis that we anticipated that it would be in the API (it was briefly in Private Preview), which was a change we made in #2046.What?
RateLimitExceptionnow extendsStripeExceptionrather thanApiExceptionChangelog
RateLimitExceptionnow extendsStripeExceptionrather thanApiExceptionStripeException(e.g.RateLimitException,InvalidRequestException, etc.) like in V1 instead of a genericApiException