Track table LOGGED/UNLOGGED persistence#288
Draft
dilame wants to merge 1 commit into
Draft
Conversation
Constraint: PostgreSQL stores LOGGED/UNLOGGED table persistence in pg_class.relpersistence.\nRejected: Recreate tables for persistence-only changes | ALTER TABLE SET LOGGED/UNLOGGED is the direct PostgreSQL operation and keeps the diff narrow.\nConfidence: high\nScope-risk: narrow\nDirective: Preserve table persistence in both schema extraction and create/alter DDL generation.\nTested: PATH="/Applications/Postgres.app/Contents/Versions/16/bin:/opt/local/bin:/opt/local/sbin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/usr/local/go/bin:/Users/bowzee/.volta/bin:/Users/bowzee/.codex/tmp/arg0/codex-arg0ugL248:/opt/homebrew/share/google-cloud-sdk/bin:/Users/bowzee/perl5/bin:/Users/bowzee/.antigravity/antigravity/bin:/opt/homebrew/opt/libpq/bin:/Users/bowzee/.local/bin:/opt/local/bin:/opt/local/sbin:/Users/bowzee/.cargo/bin:/Users/bowzee/Library/Application Support/JetBrains/Toolbox/scripts:/Applications/Codex.app/Contents/Resources" go test ./...\nNot-tested: Production migration run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_class.relpersistencein schema extractionCREATE UNLOGGED TABLEfor new unlogged tablesALTER TABLE ... SET LOGGED/UNLOGGEDwhen an existing table changes persistenceRoot Cause
pg-schema-diffdid not include table persistence in its table model, so a declarativeCREATE UNLOGGED TABLEtarget could differ from an existing logged table while the generated migration plan stayed empty.Tests
PATH="/Applications/Postgres.app/Contents/Versions/16/bin:$PATH" go test ./internal/schema -run TestSchemaTestCases/'Simple schema|Partition test' -count=1PATH="/Applications/Postgres.app/Contents/Versions/16/bin:$PATH" go test ./internal/migration_acceptance_tests -run TestTableTestCases/'Set table' -count=1PATH="/Applications/Postgres.app/Contents/Versions/16/bin:$PATH" go test ./...