Add reminders about security best practices and redact secrets in logs#45
Open
cmoresco-stripe wants to merge 1 commit intomainfrom
Open
Add reminders about security best practices and redact secrets in logs#45cmoresco-stripe wants to merge 1 commit intomainfrom
cmoresco-stripe wants to merge 1 commit intomainfrom
Conversation
Committed-By-Agent: claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STRIPE_SECRET_KEYassignments in all server files urging users not to put keys in code and pointingto https://docs.stripe.com/keys-best-practices.
cat .envin CI workflow files with a redacting version that masks secret keys (sk_), restricted keys (rk_),and webhook secrets (
whsec_) while leaving publishable keys visible.config_helper.rb): adds aredact_keyhelper and uses it in error messages so secret keys arenot printed in full.
What was changed (4 files, 20 insertions):