Skip to content

Add proposal for re-issuing KafkaUser certificate on demand#213

Merged
im-konge merged 3 commits intostrimzi:mainfrom
im-konge:re-issue-kafka-user-cert-on-demand
Apr 12, 2026
Merged

Add proposal for re-issuing KafkaUser certificate on demand#213
im-konge merged 3 commits intostrimzi:mainfrom
im-konge:re-issue-kafka-user-cert-on-demand

Conversation

@im-konge
Copy link
Copy Markdown
Member

@im-konge im-konge commented Mar 31, 2026

This proposal suggests solution for strimzi/strimzi-kafka-operator#12337.

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Copy link
Copy Markdown
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal.

I left a comment on the annotation and some nits that are mostly formal. However, I think it is important to make it clear that the renewal does not invalidate the previous certificate. So can you add a section about documentation that clarifies that this will be documented?

Comment thread 137-re-issue-kafka-user-certificate-on-demand.md Outdated
Comment thread 137-re-issue-kafka-user-certificate-on-demand.md Outdated
Comment thread 137-re-issue-kafka-user-certificate-on-demand.md Outdated
Comment thread 137-re-issue-kafka-user-certificate-on-demand.md
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge requested a review from scholzj April 2, 2026 13:51
@scholzj
Copy link
Copy Markdown
Member

scholzj commented Apr 2, 2026

@im-konge Did you had any thoughts about this?

However, I think it is important to make it clear that the renewal does not invalidate the previous certificate. So can you add a section about documentation that clarifies that this will be documented?

@im-konge
Copy link
Copy Markdown
Member Author

im-konge commented Apr 2, 2026

@im-konge Did you had any thoughts about this?

However, I think it is important to make it clear that the renewal does not invalidate the previous certificate. So can you add a section about documentation that clarifies that this will be documented?

Ah .. yeah sorry. I forgot about it, thanks for reminder.

@im-konge
Copy link
Copy Markdown
Member Author

im-konge commented Apr 2, 2026

@scholzj I just added a small section about documentation and documenting this behavior. Please have a look. Thanks!

Copy link
Copy Markdown
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. +1.

Copy link
Copy Markdown
Contributor

@sebastiangaiser sebastiangaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care 👍🏻

Comment thread 137-re-issue-kafka-user-certificate-on-demand.md Outdated
Copy link
Copy Markdown
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks @im-konge .

@im-konge
Copy link
Copy Markdown
Member Author

im-konge commented Apr 8, 2026

This proposal now has 4 +1 binding votes (including me) and 1 +1 non-binding vote. If there are no further comments until Friday 10th April EOB, I'm going to close it as approved.

@im-konge
Copy link
Copy Markdown
Member Author

im-konge commented Apr 12, 2026

Sorry I forgot to merge it on Friday. Going to do it now.

@im-konge im-konge force-pushed the re-issue-kafka-user-cert-on-demand branch from 42fd555 to 59705c2 Compare April 12, 2026 19:53
… staying valid after renewal

Signed-off-by: Lukas Kral <lukywill16@gmail.com>
@im-konge im-konge force-pushed the re-issue-kafka-user-cert-on-demand branch from 59705c2 to 683405b Compare April 12, 2026 19:54
@im-konge im-konge merged commit 737d11f into strimzi:main Apr 12, 2026
1 check passed
@im-konge im-konge deleted the re-issue-kafka-user-cert-on-demand branch April 12, 2026 19:58
@im-konge
Copy link
Copy Markdown
Member Author

Approved with 5 binding (including mine) and 1 non-binding +1 votes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants