Add proposal for re-issuing KafkaUser certificate on demand#213
Add proposal for re-issuing KafkaUser certificate on demand#213im-konge merged 3 commits intostrimzi:mainfrom
Conversation
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
scholzj
left a comment
There was a problem hiding this comment.
Thanks for the proposal.
I left a comment on the annotation and some nits that are mostly formal. However, I think it is important to make it clear that the renewal does not invalidate the previous certificate. So can you add a section about documentation that clarifies that this will be documented?
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
@im-konge Did you had any thoughts about this?
|
Ah .. yeah sorry. I forgot about it, thanks for reminder. |
|
@scholzj I just added a small section about documentation and documenting this behavior. Please have a look. Thanks! |
sebastiangaiser
left a comment
There was a problem hiding this comment.
Thanks for taking care 👍🏻
|
This proposal now has 4 +1 binding votes (including me) and 1 +1 non-binding vote. If there are no further comments until Friday 10th April EOB, I'm going to close it as approved. |
|
Sorry I forgot to merge it on Friday. Going to do it now. |
42fd555 to
59705c2
Compare
… staying valid after renewal Signed-off-by: Lukas Kral <lukywill16@gmail.com>
59705c2 to
683405b
Compare
|
Approved with 5 binding (including mine) and 1 non-binding +1 votes. |
This proposal suggests solution for strimzi/strimzi-kafka-operator#12337.