feat(server): switch server's routes to be read or write (step towards async)#2674
Merged
feat(server): switch server's routes to be read or write (step towards async)#2674
Conversation
…s async) WHAT: - Make all main_router routes use a read-write lock. - Make some routes async. WHY: This is a step towards better concurrency support when multiple users edit documents on the StrictDoc server concurrently. Many webserver requests can be served to users concurrently using async (reader lock) when only the occasional writes block the readers. Instead of turning FastAPI into a truly multi-worker concurrent setup, we first try to make maximum use of a single worker model, following the "multiple concurrent reads, single writes" approach. HOW: - Introduce read/write routes using asyncio read-write lock. - Add async to some of the most used functions (e.g., get document, get asset).
bfc0243 to
96d436b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.