Skip to content

feat: improve printed log lines around the chrome webdriver creation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanislaw merged 1 commit into from
Nov 21, 2025
Merged

feat: improve printed log lines around the chrome webdriver creation #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions html2pdf4doc/html2pdf4doc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def get_chrome_version() -> Optional[str]:
try:
print( # noqa: T201
"html2pdf4doc: "
"checking if there is Google Chrome for Testing instead of "
"Checking if there is Google Chrome for Testing instead of "
"a normal Chrome available."
)

Expand Down Expand Up @@ -302,7 +302,7 @@ def get_inches_from_millimeters(mm: float) -> float:


def get_pdf_from_html(driver: webdriver.Chrome, url: str) -> Tuple[bytes, int]:
print(f"html2pdf4doc: opening URL with ChromeDriver: {url}") # noqa: T201
print(f"html2pdf4doc: Opening URL with ChromeDriver: {url}", flush=True) # noqa: T201

driver.get(url)

Expand Down Expand Up @@ -391,7 +391,7 @@ def create_webdriver(
page_load_timeout: int,
debug: bool = False,
) -> webdriver.Chrome:
print("html2pdf4doc: creating ChromeDriver service.", flush=True) # noqa: T201
print("html2pdf4doc: Creating ChromeDriver service.", flush=True) # noqa: T201

path_to_chrome_driver: str
if chromedriver_argument is None:
Expand Down Expand Up @@ -446,14 +446,16 @@ def create_webdriver(
# Enable the capturing of everything in JS console.
webdriver_options.set_capability("goog:loggingPrefs", {"browser": "ALL"})

print("html2pdf4doc: creating ChromeDriver.", flush=True) # noqa: T201
print("html2pdf4doc: Creating ChromeDriver.", flush=True) # noqa: T201

driver = webdriver.Chrome(
options=webdriver_options,
service=service,
)
driver.set_page_load_timeout(page_load_timeout)

print("html2pdf4doc: ChromeDriver created.", flush=True) # noqa: T201

return driver


Expand Down
Loading