fix: handle null comment parameter in transaction endpoint#89
Merged
schinken merged 2 commits intostrichliste:masterfrom Apr 12, 2026
Merged
Conversation
Because PHP 8.x emits a deprecation warning when passing null to mb_strlen(). This was breaking JSON responses when creating transactions without a comment.
| throw new UserNotFoundException($userId); | ||
| } | ||
|
|
||
| $transaction = $transactionService->doTransaction($user, $amount, $comment, $quantity, $articleId, $recipientId); |
Contributor
There was a problem hiding this comment.
$comment can be null if not provided and is stored as null
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, that makes sense indeed.
Co-authored-by: Christopher Schirner <christopher.schirner@thomann.io>
schinken
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋🏼
It's my first PR here.
I'm a user of strichliste, we have it in my hacker space next to the drinks' fridge.
Because PHP 8.x emits a deprecation warning when passing null to
mb_strlen().This was breaking JSON responses when creating transactions without a comment.