Skip to content

Scrum 151 ci cd with GitHub actions#16

Merged
QuanUTS merged 8 commits into
mainfrom
SCRUM-151-CI-CD-with-GitHub-Actions
May 20, 2025
Merged

Scrum 151 ci cd with GitHub actions#16
QuanUTS merged 8 commits into
mainfrom
SCRUM-151-CI-CD-with-GitHub-Actions

Conversation

@QuanUTS
Copy link
Copy Markdown
Collaborator

@QuanUTS QuanUTS commented May 20, 2025

No description provided.

@QuanUTS
Copy link
Copy Markdown
Collaborator Author

QuanUTS commented May 20, 2025

Model evaluation metrics on 3 subsets:

Subset Loss Accuracy Top-5 Accuracy
Train 0.0423969 0.993065 1
Validation 2.05219 0.591716 0.831361
Test 2.32801 0.488372 0.837209

You can view full task results here

@QuanUTS
Copy link
Copy Markdown
Collaborator Author

QuanUTS commented May 20, 2025

Model evaluation metrics on 3 subsets:

Subset Loss Accuracy Top-5 Accuracy
Train 0.00969788 0.998613 1
Validation 2.2651 0.60355 0.872781
Test 2.34377 0.573643 0.841085

You can view full task results here

@QuanUTS QuanUTS merged commit 9554c8e into main May 20, 2025
5 checks passed
@QuanUTS QuanUTS requested a review from Copilot May 20, 2025 10:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CI/CD pipeline for the SyntaxSquad ML Pipeline by updating dependency versions, refactoring Python reporting logic, and consolidating GitHub Actions workflows for improved automation.

  • Updated dependency definitions in requirements.txt to use flexible specifiers.
  • Refactored pipeline reporting functions to generate clearer PR comments and added a new "get_reported_table" function.
  • Adjusted workflow steps in the GitHub Actions pipeline, including splitting job responsibilities and increasing the wait time for FastAPI startup.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
serving/requirements.txt Updated dependency specifications for FastAPI and numpy.
cicd/pipeline_reports.py Refactored functions to improve reporting of ClearML task metrics.
.github/workflows/pipeline.yaml Modified CI/CD workflow steps and added a new job to test remote tasks, updated deployment wait time.
.github/workflows/ci.yaml Removed outdated CI workflow configuration as it's been consolidated.

Comment thread serving/requirements.txt
fastapi==0.115.12
numpy==2.2.6
fastapi[standard]
numpy == 1.26.4
Copy link

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the extra space around '==' in the numpy dependency to avoid potential installation issues; it should be 'numpy==1.26.4'.

Suggested change
numpy == 1.26.4
numpy==1.26.4

Copilot uses AI. Check for mistakes.
Comment on lines +210 to 211
sleep 240 # Wait for 4 minutes to start the server and download artifacts
curl -f http://localhost:$FASTAPI_PORT/health || exit 1 # Verify the server is running
Copy link

Copilot AI May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a fixed long sleep duration, consider implementing a polling mechanism to check for FastAPI server readiness to optimize pipeline execution time.

Suggested change
sleep 240 # Wait for 4 minutes to start the server and download artifacts
curl -f http://localhost:$FASTAPI_PORT/health || exit 1 # Verify the server is running
# Poll the FastAPI server's health endpoint until it is ready or timeout is reached
for i in {1..60}; do # Retry up to 60 times (1 minute timeout with 1-second intervals)
if curl -f http://localhost:$FASTAPI_PORT/health; then
echo "FastAPI server is ready!"
break
fi
echo "Waiting for FastAPI server to be ready... (attempt $i)"
sleep 1
done
if ! curl -f http://localhost:$FASTAPI_PORT/health; then
echo "FastAPI server failed to start within the timeout period."
exit 1
fi

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants