feat: Add an option to control connection cleanup#392
Merged
BewareMyPower merged 1 commit intostreamnative:masterfrom Feb 11, 2026
Merged
feat: Add an option to control connection cleanup#392BewareMyPower merged 1 commit intostreamnative:masterfrom
BewareMyPower merged 1 commit intostreamnative:masterfrom
Conversation
The `check_connections()` function is responsible for cleaning up unused connections. Now that `update_topics` is periodically called for `multi` topics (partitions) as well as for topic regex, it's important that there be a cached connection to use. This commit makes changes to refresh a timestamp when a connection is used and only delete it after a certain configured idle time has passed. A configurable option has been added to give the user full control of the connection cleanup behavior. Fixes: streamnative#391
Contributor
Author
|
@BewareMyPower this is a follow-up to my recent fix for the connection cleanup race condition. Thank you! |
BewareMyPower
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check_connections()function is responsible for cleaning up unused connections. Now thatupdate_topicsis periodically called formultitopics (partitions) as well as for topic regex, it's important that there be a cached connection to use. This commit makes changes to refresh a timestamp when a connection is used and only delete it after a certain configured idle time has passed. A configurable option has been added to give the user full control of the connection cleanup behavior.Fixes: #391