fix(producer): prevent send requests with 0 as num_messages#377
Merged
BewareMyPower merged 2 commits intomasterfrom Dec 17, 2025
Merged
fix(producer): prevent send requests with 0 as num_messages#377BewareMyPower merged 2 commits intomasterfrom
BewareMyPower merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #376 by preventing the producer from sending messages with num_messages_in_batch = 0 to the Pulsar broker. When send_batch() is called on a partitioned producer with no pending messages in some partitions, the fix ensures those partitions signal the flush completion without attempting to send an empty batch.
Key changes:
- Added early return in
message_send_loopwhen counter is 0 after extracting flush item - Created a new
test_utilsmodule to consolidate common test helper functions - Added test coverage for flushing on partitioned topics where some partitions have no messages
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/producer.rs | Adds the core fix to prevent sending messages with 0 count; refactors test helper usage to use new test_utils module |
| src/test_utils.rs | New module containing new_pulsar() and create_partitioned_topic() test helper functions extracted from producer tests |
| src/lib.rs | Adds test_utils module; refactors existing tests to use test_utils helpers; adds new test for flush on partitioned topics |
| src/reader.rs | Reorders imports to follow consistent style (std, external crates, then internal modules) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #376