Skip to content

fix(producer): prevent send requests with 0 as num_messages#377

Merged
BewareMyPower merged 2 commits intomasterfrom
bewaremypower/fix-send-batch-partitioned
Dec 17, 2025
Merged

fix(producer): prevent send requests with 0 as num_messages#377
BewareMyPower merged 2 commits intomasterfrom
bewaremypower/fix-send-batch-partitioned

Conversation

@BewareMyPower
Copy link
Contributor

fixes #376

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #376 by preventing the producer from sending messages with num_messages_in_batch = 0 to the Pulsar broker. When send_batch() is called on a partitioned producer with no pending messages in some partitions, the fix ensures those partitions signal the flush completion without attempting to send an empty batch.

Key changes:

  • Added early return in message_send_loop when counter is 0 after extracting flush item
  • Created a new test_utils module to consolidate common test helper functions
  • Added test coverage for flushing on partitioned topics where some partitions have no messages

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/producer.rs Adds the core fix to prevent sending messages with 0 count; refactors test helper usage to use new test_utils module
src/test_utils.rs New module containing new_pulsar() and create_partitioned_topic() test helper functions extracted from producer tests
src/lib.rs Adds test_utils module; refactors existing tests to use test_utils helpers; adds new test for flush on partitioned topics
src/reader.rs Reorders imports to follow consistent style (std, external crates, then internal modules)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@BewareMyPower BewareMyPower merged commit d963be5 into master Dec 17, 2025
14 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/fix-send-batch-partitioned branch December 17, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

send_batch could send entries whose batch size is 0 when the topic is partitioned

1 participant