Fix to Producer Busy error on reconnect#280
Open
CMoore-Darwinium wants to merge 3 commits intostreamnative:masterfrom
Open
Fix to Producer Busy error on reconnect#280CMoore-Darwinium wants to merge 3 commits intostreamnative:masterfrom
CMoore-Darwinium wants to merge 3 commits intostreamnative:masterfrom
Conversation
tisonkun
suggested changes
Jun 2, 2023
Contributor
tisonkun
left a comment
There was a problem hiding this comment.
Please run cargo +nightly fmt --all locally to fix the style issue.
I'd like to help you but your branch name conflict with upstream so it's hard to directly push on your changes.
➜ pulsar-rs git:(darwinium-com/master) git push
fatal: The upstream branch of your current branch does not match
the name of your current branch. To push to the upstream branch
on the remote, use
git push origin HEAD:refs/pull/280/head
To push to the branch of the same name on the remote, use
git push origin HEAD
To choose either option permanently, see push.default in 'git help config'.
To avoid automatically configuring an upstream branch when its name
won't match the local branch, see option 'simple' of branch.autoSetupMerge
in 'git help config'.
➜ pulsar-rs git:(darwinium-com/master) git push origin HEAD:refs/pull/280/head
Enumerating objects: 34, done.
Counting objects: 100% (31/31), done.
Delta compression using up to 10 threads
Compressing objects: 100% (24/24), done.
Writing objects: 100% (24/24), 4.15 KiB | 4.15 MiB/s, done.
Total 24 (delta 19), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (19/19), completed with 6 local objects.
To https://github.com/streamnative/pulsar-rs.git
! [remote rejected] HEAD -> refs/pull/280/head (deny updating a hidden ref)
error: failed to push some refs to 'https://github.com/streamnative/pulsar-rs.git'
tisonkun
reviewed
Jun 2, 2023
Contributor
tisonkun
left a comment
There was a problem hiding this comment.
Besides, can you pick the test cases in Golang patch also so that we can prevent regression later?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a fix for this issue, that we've been getting:
apache/pulsar#13342
It's a direct clone of this Go fix, which is why it uses an atomic int even though it doesn't really need to:
https://github.com/apache/pulsar-client-go/pull/582/files