Validate the encoder for dual output before going live#5707
Open
mhoyer-streamlabs wants to merge 6 commits intomasterfrom
Open
Validate the encoder for dual output before going live#5707mhoyer-streamlabs wants to merge 6 commits intomasterfrom
mhoyer-streamlabs wants to merge 6 commits intomasterfrom
Conversation
Handle strings correctly
sandboxcoder
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user is able to select an encoder in Output settings based on the main stream service, but if they go live with Dual Output that encoder is never validated for the additional service. If the encoder is invalid, the stream fails but the user isn't notified and no errors are logged. Added a function to the backend to validate encoders and use that to prevent this from happening. On
Go Live, validate the encoder if using Dual Output but NOT using the restream server - that is handled elsewhere. If the encoder is invalid, prompt the user to default to x264 or select their own in settings.To reproduce:
Stream to custom ingestStreaming Servicesas stream type and select YouTube RTMPSUse recommended settingsNVIDIA NVENC AV1Go Liveand selectDual Output, choose YouTube and any other destination (I tested with Twitch and Kick)Confirm and Go Livewill prompt for an encoder change