Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(printer-models): PrinterModel Protocol + ModelRegistry for plugin discovery #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(printer-models): PrinterModel Protocol + ModelRegistry for plugin discovery #48
Changes from all commits
7e6ca4e33a436905c13c7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The substring match
sig in pjl_stringwill returnTruefor any input ifsigis an empty string. This could lead to incorrect model resolution if a plugin is misconfigured with an empty signature. Adding a truthiness check ensures that only valid, non-empty signatures are matched.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the PJL lookup, an empty
snmp_model_oid_value_substrwould cause this method to match any OID value. Adding a check for a non-empty substring prevents accidental matches on misconfigured plugins.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FakePtModeldoes not implement thePrinterModelprotocol (missingquery_status,width_to_pixels, andbuild_print_job). While the registry currently only uses attributes for lookup, this incomplete implementation will failmypy --strictchecks andisinstance(fake, PrinterModel)runtime checks, making the tests fragile and unrepresentative of real plugins.Uh oh!
There was an error while loading. Please reload this page.