Move Boole dialect to the StrataBoole package#1210
Open
atomb wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
Waiting-For-Review
github_actions
…missing copyright headers to StrataBoole.lean and StrataBooleTest.lean to fix the lint check. Move the StrataBoole build into the main build_and_test_lean job instead of a separate job.
shigoel
reviewed
May 21, 2026
shigoel
reviewed
May 21, 2026
Contributor
|
LGTM in general; left a couple comments above. |
shigoel
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Boole dialect to standalone package
Extract the Boole dialect into its own
StrataBooleLake package with a dependency on the mainStratapackage. This enables faster incremental builds for Boole-specific work and cleaner separation of concerns.Changes
Strata/Languages/Boole/source files toStrataBoole/StrataBoole/StrataBoole/StrataBooleTest/StrataBoole/lakefile.tomlwithStrataas a dependencyStrataBoole/StrataBooleTest.leanroot module importing all test filesMetaVerifier.leanto add required meta imports (Lean.Meta.Eval,Lean.Meta.Tactic.Rewrite,Lean.Meta.Tactic.Unfold) and definegenSMTVCsBooleas a standalone function for the tactic infrastructureStrata.Languages.Boole.*toStrataBoole.*#guard_msgsexpected output to reflect shifted source positionsStrataBoolepackageStratapackage (Strata.lean,MetaVerifier.lean,StrataMainLib.lean)