Skip to content

pyAnalyzeLaurel: classify UserError diagnostics as known limitations #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julesmt wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pyAnalyzeLaurel: classify UserError diagnostics as known limitations #1118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
792e14b
pyAnalyzeLaurel: classify UserError diagnostics as known limitations
May 5, 2026
4708b82
Michael's suggestion 1
julesmt May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion StrataMain.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,21 @@ def pyAnalyzeLaurelCommand : Command where
let coreProgram ←
match coreProgramOption with
| none =>
exitPyAnalyzeInternalError s!"Laurel to Core translation failed: {laurelTranslateErrors}"
let msg := s!"Laurel to Core translation failed: {laurelTranslateErrors}"
-- Classify by worst-severity diagnostic: StrataBug (tool bug) outranks
-- UserError (user-actionable) outranks NotYetImplemented (wait-for-support).
-- An empty list or warnings-only failure with `coreProgramOption = none`
-- is itself a tool bug (translation should not silently fail).
if laurelTranslateErrors.isEmpty
∨ laurelTranslateErrors.any (·.type == .StrataBug) then
exitPyAnalyzeInternalError msg
else if laurelTranslateErrors.any (·.type == .UserError) then
exitPyAnalyzeUserError msg
else if laurelTranslateErrors.any (·.type == .NotYetImplemented) then
exitPyAnalyzeKnownLimitation msg
Comment thread
julesmt marked this conversation as resolved.
else
-- Only warnings, but translation failed → unexpected.
exitPyAnalyzeInternalError msg
| some core => pure core

if verbose then
Expand Down
Loading