Merged
Conversation
|
This worked perfectly for me, thanks! |
|
It would be nice to merge :) |
|
we need this in production pack! that would be nice. |
Contributor
Author
|
In the meantime, my fork is available on npm: @roboto_/strapi-blocks-react |
remidej
reviewed
Oct 31, 2024
Contributor
remidej
left a comment
There was a problem hiding this comment.
Looks good, could you just add a unit test too?
And sorry I wasn't aware of this PR, it's been a while so if you don't want to get back to it we can make another PR internally
|
@remidej Could you take a look into this |
remidej
previously approved these changes
Jan 30, 2025
remidej
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Transforms
\n,\r\nand\rinto<br />tags in<Text />Why is it needed?
Fixes #37
How to test it?
<BlocksRenderer /><br />tags